From: jonghwa3.lee@samsung.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, a.zummo@towertech.it,
rtc-linux@googlegroups.com
Subject: Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.
Date: Thu, 07 Feb 2013 12:37:49 +0900 [thread overview]
Message-ID: <5113218D.9040304@samsung.com> (raw)
In-Reply-To: <20130206182817.3af25596.akpm@linux-foundation.org>
On 2013년 02월 07일 11:28, Andrew Morton wrote:
> On Thu, 07 Feb 2013 10:43:23 +0900 jonghwa3.lee@samsung.com wrote:
>
>>> The best way of handling this sort of thing is for the driver to probe
>>> the hardware, work out its capabilities and "do the right thing".
>>>
>>> The second best way is to require that the user add certain module
>>> parameters to enable the functionality.
>>>
>>
>> How do we create sysfs node for enabling these options?
>
> I suggest using module_param[_named](), so users can execute "modprobe
> max8997 wtsr=1". Or, if the driver is built into vmlinux, add
> "max8997.wtsr=1" to the kernel boot command line.
>
> Documentation/kernel-parameters.txt mentions this.
>
Sorry, my question was incorrect, I meant to suggest to create sysfs node not to
ask you to let me know how to implement sysfs node. Anyway I'll apply your
comment and re-patch it soon.
Thanks,
Jonghwa
next prev parent reply other threads:[~2013-02-07 3:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:23 [PATCH] rtc: max8997: Add driver for max8997 rtc Jonghwa Lee
2013-02-06 21:06 ` Andrew Morton
2013-02-07 1:43 ` jonghwa3.lee
2013-02-07 2:28 ` Andrew Morton
2013-02-07 3:37 ` jonghwa3.lee [this message]
2013-02-07 4:14 ` devendra.aaru
2013-02-07 4:22 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5113218D.9040304@samsung.com \
--to=jonghwa3.lee@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox