* [PATCH 1/1]linux-usb: fix the idProduct value to be compatible with current CPU in initializers.c
@ 2013-02-07 7:32 fangxiaozhi 00110321
2013-02-07 11:38 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: fangxiaozhi 00110321 @ 2013-02-07 7:32 UTC (permalink / raw)
To: linux-usb
Cc: linux-kernel, zihan, Lin.Lei, greg, neil.yi, wangyuhua, huqiao36,
balbi, mdharm-usb, sebastian
From: fangxiaozhi <huananhu@huawei.com>
1. The idProduct is little endian, so make sure its value to be compatible with the current CPU. Make no break on big endian processors.
Signed-off-by: fangxiaozhi <huananhu@huawei.com>
--------------------------------------------------------------------
diff -uprN linux-3.8-rc6_orig/drivers/usb/storage/initializers.c linux-3.8-rc6/drivers/usb/storage/initializers.c
--- linux-3.8-rc6_orig/drivers/usb/storage/initializers.c 2013-02-06 14:48:51.564355283 +0800
+++ linux-3.8-rc6/drivers/usb/storage/initializers.c 2013-02-07 15:29:59.929482630 +0800
@@ -147,7 +147,7 @@ static int usb_stor_huawei_dongles_pid(s
int idProduct;
idesc = &us->pusb_intf->cur_altsetting->desc;
- idProduct = us->pusb_dev->descriptor.idProduct;
+ idProduct = le16_to_cpu(us->pusb_dev->descriptor.idProduct);
/* The first port is CDROM,
* means the dongle in the single port mode,
* and a switch command is required to be sent. */
@@ -169,7 +169,7 @@ int usb_stor_huawei_init(struct us_data
int result = 0;
if (usb_stor_huawei_dongles_pid(us)) {
- if (us->pusb_dev->descriptor.idProduct >= 0x1446)
+ if (le16_to_cpu(us->pusb_dev->descriptor.idProduct) >= 0x1446)
result = usb_stor_huawei_scsi_init(us);
else
result = usb_stor_huawei_feature_init(us);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1]linux-usb: fix the idProduct value to be compatible with current CPU in initializers.c
2013-02-07 7:32 [PATCH 1/1]linux-usb: fix the idProduct value to be compatible with current CPU in initializers.c fangxiaozhi 00110321
@ 2013-02-07 11:38 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2013-02-07 11:38 UTC (permalink / raw)
To: fangxiaozhi 00110321
Cc: linux-usb, linux-kernel, zihan, Lin.Lei, greg, neil.yi, wangyuhua,
huqiao36, balbi, mdharm-usb, sebastian
Hello.
On 07-02-2013 11:32, fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@huawei.com>
> 1. The idProduct is little endian, so make sure its value to be compatible with the current CPU. Make no break on big endian processors.
Wrap your lines reasonable at 80 columns at last (better somewht less).
And why "1." here? Where is "2."?
> Signed-off-by: fangxiaozhi <huananhu@huawei.com>
> --------------------------------------------------------------------
Either use --- tearline, or no tearline at all.
WBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-07 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-07 7:32 [PATCH 1/1]linux-usb: fix the idProduct value to be compatible with current CPU in initializers.c fangxiaozhi 00110321
2013-02-07 11:38 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox