From: Stephen Warren <swarren@wwwdotorg.org>
To: kishon <kishon@ti.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>,
balbi@ti.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy directory
Date: Thu, 07 Feb 2013 09:56:12 -0700 [thread overview]
Message-ID: <5113DCAC.6080003@wwwdotorg.org> (raw)
In-Reply-To: <5113AE42.8090401@ti.com>
On 02/07/2013 06:38 AM, kishon wrote:
> On Thursday 07 February 2013 05:02 PM, Venu Byravarasu wrote:
>> As drivers/usb/otg/otg.c contains most of the PHY related APIs which
>> are not OTG specific, moving them to more logical place under
>> drivers/usb/phy.
>> diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
>> index b13faa1..886be13 100644
>> --- a/drivers/usb/phy/Makefile
>> +++ b/drivers/usb/phy/Makefile
>> @@ -4,6 +4,7 @@
>>
>> ccflags-$(CONFIG_USB_DEBUG) := -DDEBUG
>>
>> +obj-$(CONFIG_USB_COMMON) += phy.o
>
> I think we should have a separate config for PHYs. There might be
> controllers which dont need separate PHY. But we can have that as a
> separate patch later since we might want to change the Kconfig of other
> UDC drivers.
>> +/*
>> + * phy.c -- USB PHY utility code
>> + *
>> + * Copyright (C) 2004 Texas Instruments
>
> You can update this to 2013.
I'm not sure if anyone other that TI can do that?
>> +EXPORT_SYMBOL_GPL(usb_bind_phy);
>> +
>> +
>
> Unnecessary spaces here.
Thanks for the review. It was very difficult to find you review comments
since you quoted the entire patch rather than just the few pieces you
were commenting on...
> You might want to do this patch after applying *[PATCH] usb: otg: use
> try_module_get in all usb_get_phy functions and add missing module_put*
> by Marc.
Venu, please make sure you include the changes in that patch in your
Tegra USB/PHY driver rework too, before you post it upstream.
next prev parent reply other threads:[~2013-02-07 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 11:32 [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy directory Venu Byravarasu
2013-02-07 13:38 ` kishon
2013-02-07 16:56 ` Stephen Warren [this message]
2013-02-08 6:39 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5113DCAC.6080003@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox