From: "H. Peter Anvin" <hpa@zytor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Landley <rob@landley.net>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Eric Dumazet <edumazet@google.com>,
Neil Horman <nhorman@tuxdriver.com>,
Yuchung Cheng <ycheng@google.com>,
Shan Wei <davidshan@tencent.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
netdev@vger.kernel.org, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH] tcp: sysctl to disable TCP simultaneous connect
Date: Thu, 07 Feb 2013 11:29:08 -0800 [thread overview]
Message-ID: <51140084.3080902@zytor.com> (raw)
In-Reply-To: <CAGXu5jJiupzommJYPEYQnk-4i9FUKai0NcPnihLN-QpWV64jtQ@mail.gmail.com>
On 02/07/2013 10:44 AM, Kees Cook wrote:
>>
>> This patch probably also breaks TCP STUNT that is used by some applications for NAT
>> traversal.
>
> The patch would not break it -- it defaults the sysctl to staying enabled.
>
> If you mean the documentation should be updated, sure, that's easy to do.
>
> David: I know you aren't a fan of this patch, but I'd like to try to
> convince you. :) This leaves the feature enabled and add a toggle for
> systems (like Chrome OS) that don't want to risk this DoS at all.
> There are so very many other toggle, I don't see why this one would be
> a problem to add.
>
It is not just STUNT, but in NAT-less configurations behind stateful
firewalls (which is expected to be the norm for IPv6), TCP rendezvous
via crossed SYN is a very effective way to establish peer-to-peer
connections.
-hpa
next prev parent reply other threads:[~2013-02-07 19:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 17:52 [PATCH] tcp: sysctl to disable TCP simultaneous connect Kees Cook
2013-02-07 18:15 ` David Miller
2013-02-07 18:39 ` Stephen Hemminger
2013-02-07 18:44 ` Kees Cook
2013-02-07 19:29 ` H. Peter Anvin [this message]
2013-02-07 19:29 ` David Miller
2013-02-15 5:30 ` Eric W. Biederman
2013-02-15 6:41 ` Kees Cook
2013-02-15 7:10 ` Eric W. Biederman
2013-02-15 7:55 ` Willy Tarreau
2013-02-15 10:31 ` Eric W. Biederman
2013-02-15 10:47 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51140084.3080902@zytor.com \
--to=hpa@zytor.com \
--cc=davem@davemloft.net \
--cc=davidshan@tencent.com \
--cc=edumazet@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=keescook@chromium.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rob@landley.net \
--cc=stephen@networkplumber.org \
--cc=w@1wt.eu \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox