From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759371Ab3BGUSe (ORCPT ); Thu, 7 Feb 2013 15:18:34 -0500 Received: from mms1.broadcom.com ([216.31.210.17]:2649 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759334Ab3BGUSc (ORCPT ); Thu, 7 Feb 2013 15:18:32 -0500 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Message-ID: <51140C0F.5070209@broadcom.com> Date: Thu, 7 Feb 2013 21:18:23 +0100 From: "Arend van Spriel" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Tim Gardner" cc: linux-kernel@vger.kernel.org, "Brett Rudley" , "Franky (Zhenhui) Lin" , "Hante Meuleman" , "John W. Linville" , "Pieter-Paul Giesberts" , "Seth Forshee" , "Hauke Mehrtens" , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH wireless-next] brcmsmac: fix u16 overflow warning References: <1360265735-42450-1-git-send-email-tim.gardner@canonical.com> In-Reply-To: <1360265735-42450-1-git-send-email-tim.gardner@canonical.com> X-Enigmail-Version: 1.4.6 X-WSS-ID: 7D0AD41E1YS1946450-01-01 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2013 08:35 PM, Tim Gardner wrote: > DOT11_MIN_BEACON_PERIOD and DOT11_MAX_BEACON_PERIOD are > superfluous. The only invalid beacon period is 0. Comparing > a 16 bit quantity to 0xffff also causes a compile warning: > > drivers/net/wireless/brcm80211/brcmsmac/main.c:5560 brcms_c_set_beacon_period() > warn: impossible condition '(period > 65535) => (0-65535 > 65535)' > > Observed from smatch analysis. > > Cc: Brett Rudley > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: "John W. Linville" > Cc: Pieter-Paul Giesberts > Cc: Seth Forshee > Cc: Hauke Mehrtens > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list@broadcom.com > Cc: netdev@vger.kernel.org Acked-by: Arend van Spriel > Signed-off-by: Tim Gardner > --- > drivers/net/wireless/brcm80211/brcmsmac/main.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c > index c26992a..080b54d 100644 > --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c > +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c > @@ -101,8 +101,6 @@ > #define DOT11_RTS_LEN 16 > #define DOT11_CTS_LEN 10 > #define DOT11_BA_BITMAP_LEN 128 > -#define DOT11_MIN_BEACON_PERIOD 1 > -#define DOT11_MAX_BEACON_PERIOD 0xFFFF > #define DOT11_MAXNUMFRAGS 16 > #define DOT11_MAX_FRAG_LEN 2346 > > @@ -5555,8 +5553,7 @@ int brcms_c_set_rateset(struct brcms_c_info *wlc, struct brcm_rateset *rs) > > int brcms_c_set_beacon_period(struct brcms_c_info *wlc, u16 period) > { > - if (period < DOT11_MIN_BEACON_PERIOD || > - period > DOT11_MAX_BEACON_PERIOD) > + if (period == 0) > return -EINVAL; > > wlc->default_bss->beacon_period = period; >