From: John Stultz <john.stultz@linaro.org>
To: paulmck@linux.vnet.ibm.com
Cc: Michel Lespinasse <walken@google.com>,
Rik van Riel <riel@redhat.com>, Ingo Molnar <mingo@redhat.com>,
David Howells <dhowells@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <edumazet@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/6] kernel: implement queue spinlock API
Date: Thu, 07 Feb 2013 15:14:05 -0800 [thread overview]
Message-ID: <5114353D.1060202@linaro.org> (raw)
In-Reply-To: <20130207223434.GG2545@linux.vnet.ibm.com>
On 02/07/2013 02:34 PM, Paul E. McKenney wrote:
> On Tue, Jan 22, 2013 at 03:13:30PM -0800, Michel Lespinasse wrote:
>> Introduce queue spinlocks, to be used in situations where it is desired
>> to have good throughput even under the occasional high-contention situation.
>>
>> This initial implementation is based on the classic MCS spinlock,
>> because I think this represents the nicest API we can hope for in a
>> fast queue spinlock algorithm. The MCS spinlock has known limitations
>> in that it performs very well under high contention, but is not as
>> good as the ticket spinlock under low contention. I will address these
>> limitations in a later patch, which will propose an alternative,
>> higher performance implementation using (mostly) the same API.
>>
>> Sample use case acquiring mystruct->lock:
>>
>> struct q_spinlock_node node;
>>
>> q_spin_lock(&mystruct->lock, &node);
>> ...
>> q_spin_unlock(&mystruct->lock, &node);
> It is possible to keep the normal API for MCS locks by having the lock
> holder remember the parameter in the lock word itself. While spinning,
> the node is on the stack, is not needed once the lock is acquired.
> The pointer to the next node in the queue -is- needed, but this can be
> stored in the lock word.
>
> I believe that John Stultz worked on something like this some years back,
> so added him to CC.
Oh yea, its been quite awhile.
Here are some of the discussion threads google remembers for me:
http://marc.info/?l=lse-tech&m=101227079817027&w=2
http://marc.info/?l=lse-tech&m=101380783015065&w=2 (missing the patch)
http://marc.info/?l=lse-tech&m=101380783615084&w=2 (patch for above)
thanks
-john
next prev parent reply other threads:[~2013-02-07 23:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 23:13 [RFC PATCH 0/6] fast queue spinlocks Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 1/6] kernel: implement queue spinlock API Michel Lespinasse
2013-02-07 22:34 ` Paul E. McKenney
2013-02-07 22:56 ` Eric Dumazet
2013-02-07 23:53 ` Paul E. McKenney
2013-02-07 23:58 ` Michel Lespinasse
2013-02-08 0:03 ` Eric Dumazet
2013-02-08 0:40 ` Paul E. McKenney
2013-02-08 3:48 ` Michel Lespinasse
2013-02-08 4:36 ` Paul E. McKenney
2013-02-08 5:03 ` Paul E. McKenney
2013-02-08 5:11 ` Michel Lespinasse
2013-02-08 16:17 ` Paul E. McKenney
2013-02-07 23:14 ` John Stultz [this message]
2013-02-08 0:35 ` Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 2/6] net: convert qdisc busylock to use " Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 3/6] ipc: convert ipc objects " Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 4/6] kernel: faster queue spinlock implementation Michel Lespinasse
2013-01-23 21:55 ` Rik van Riel
2013-01-23 23:52 ` Michel Lespinasse
2013-01-24 0:18 ` Eric Dumazet
2013-01-25 20:30 ` [RFC PATCH 7/6] kernel: document fast queue spinlocks Rik van Riel
2013-01-22 23:13 ` [RFC PATCH 5/6] net: qdisc busylock updates to account for queue spinlock api change Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 6/6] ipc: object locking " Michel Lespinasse
2013-01-22 23:17 ` [RFC PATCH 0/6] fast queue spinlocks Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5114353D.1060202@linaro.org \
--to=john.stultz@linaro.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).