From: Andreas Larsson <andreas@gaisler.com>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
spi-devel-general@lists.sourceforge.net,
Mingkai Hu <Mingkai.hu@freescale.com>,
Joakim Tjernlund <Joakim.Tjernlund@transmode.se>,
Kumar Gala <galak@kernel.crashing.org>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH v2 7/7] spi: spi-fsl-spi: Add support for gpio chipselects for GRLIB type cores
Date: Fri, 08 Feb 2013 08:46:42 +0100 [thread overview]
Message-ID: <5114AD62.1070909@gaisler.com> (raw)
In-Reply-To: <20130207160821.GA22224@lizard.gateway.2wire.net>
On 2013-02-07 17:08, Anton Vorontsov wrote:
> On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote:
>> struct fsl_spi_reg *reg_base;
>> - int retval;
>> + int retval, desel;
>
> We don't usually place variable declarations on the same line, unless the
> variables are closely related.
>
>> u32 hw_mode;
>> struct spi_mpc8xxx_cs *cs = spi->controller_state;
>>
>> @@ -456,12 +456,45 @@ static int fsl_spi_setup(struct spi_device *spi)
>> return retval;
>> }
>>
>> + if (mpc8xxx_spi->type == TYPE_GRLIB) {
>> + if (gpio_is_valid(spi->cs_gpio)) {
>
> <- You can place the 'int desel;' here, limiting the visibility for it.
Thanks for the feedback!
I'll put that in v3. This last patch needs to wait for the other
patchset I mentioned anyway.
Cheers,
Andreas
next prev parent reply other threads:[~2013-02-08 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 13:12 [PATCH v2 0/7] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 1/7] spi: spi-fsl-spi: Make driver usable in CPU mode outside of an FSL_SOC environment Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 2/7] spi: spi-fsl-spi: Make sure in spi_fsl_setup that chipselect becomes inactive Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 3/7] spi: spi-fsl-spi: Move setting non-zero tx and rx shifts to a function accessed by a function pointer Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 4/7] spi: spi-fsl-spi: Introduce a type for the driver Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 6/7] spi: spi-fsl-spi: Add support for Aeroflex Gaisler GRLIB cores normally running on SPARC Andreas Larsson
2013-02-07 13:12 ` [PATCH v2 7/7] spi: spi-fsl-spi: Add support for gpio chipselects for GRLIB type cores Andreas Larsson
2013-02-07 16:08 ` Anton Vorontsov
2013-02-08 7:46 ` Andreas Larsson [this message]
2013-03-02 21:34 ` Grant Likely
2013-02-07 13:38 ` [PATCH v2 4/7 RESEND] spi: spi-fsl-spi: Introduce a type for the driver Andreas Larsson
2013-02-07 16:08 ` [PATCH v2 0/7] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5114AD62.1070909@gaisler.com \
--to=andreas@gaisler.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=Mingkai.hu@freescale.com \
--cc=anton@enomsg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=software@gaisler.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox