From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465AbcAHJJn (ORCPT ); Fri, 8 Jan 2016 04:09:43 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:63448 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbcAHJJk (ORCPT ); Fri, 8 Jan 2016 04:09:40 -0500 From: Arnd Bergmann To: Yury Norov Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Date: Fri, 08 Jan 2016 10:08:44 +0100 Message-ID: <5115829.mX1Uk4EoYk@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1452209679-19445-12-git-send-email-ynorov@caviumnetworks.com> References: <1452209679-19445-1-git-send-email-ynorov@caviumnetworks.com> <1452209679-19445-12-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:WcXoE5PaVzB+maIEm6gw7it9+YEHtxFTv0X6yrKi4qV2YXUOQdd JOFf40hP9C997S3c/JfhkBzap16A+ltkG597QsDEwbSMGtEy3fdFTRjIH8bHiHsXSUw5ckO sctV+ijcl3xJIxNe2mqUsbfzUyDOqH7x8Dgs6JOWuyYL4tWHStZuqm3qlfcsYq8dYPs7ajV sTVEoNRBoYEvzgCy3D1VA== X-UI-Out-Filterresults: notjunk:1;V01:K0:mDrst2rFQjQ=:RQabvvj4kKC7IPsVd+Dgex 6GYeyI+JYVXs72S5mlmAh/RAgVbKJWDxIylVehxBAoqPJDzeI8vdpD128Ov0FnGRz7yvs7N/m n6SroJYNzlreQyFo6qyCwesy8uso+iYmyglrq+qAaH45l2F3NzleOgf03Oj4BkRbW2Ox36NMZ xtqbmc7T/JgcL6fgrAh81EbHuD5riiaK3YM3xpOS45X+dXIzSoAGB0Fk/0QWoGaW4GO18sxUT x0S7rmDUUJ4HaG95L78ZtJG6ATBcaRlMXKDSj1VBapiGjdpevmh/hJicUZd85/GSAZz5XAoC5 2q79OOAIjaQ73r3qOv/0YAQeuEcCmmmWV4EmAvYnjQHZLTczwJsh1BV8McTeVDrMyvG0bfJrG QbB210OXx2iXpECKEHVBJZmrb9H/rXhtmUz8+NjyA3Mc0XyI7K1QorFuhg5rqMpv+qgsApB4G ESQt0yqMhKXbkmDMxY+3Mc6ESMPW3W9dW5OHzCQ8j2cIS9vhZl+H1sh1ZvV1PzP5I3/4UsgZW HJhY2vBjx2VpIrc7T7GfgP9XqFf1Ynu2VG/VCKCq+ydND2mCwNWLfNEq8qtHk25KRlLiJObfH F6ylgmi8GIGEnTReaozz1D1DSX96LAolpn2Oa2HBwdPoBRfWrGRT6K4IWBSsPnVTWL65eR3Uw 7lEvEElOpGQA31Z7Yxpy1ZihmusYmWp+aN3cleZOv+SFXATpcCOrB0vLqxHy5JF8SvsGlOKLE 3XkqFVM/jpaBO3QM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 08 January 2016 02:34:29 Yury Norov wrote: > + > +#include "../../../fs/compat_binfmt_elf.c" > This is the wrong file, you have to include fs/binfmt_elf.c, otherwise you pick up the same definitions that you have for the other one. Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c and use fs/compat_binfmt_elf.c here if that makes the code nicer, you just can use the compat file for both or things get ugly because of the extra indirections. Arnd