From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DCC9314A6A for ; Tue, 23 Dec 2025 20:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766522118; cv=none; b=pMSh4Z9JD3uMscRfTCm5UiqYu7RL1abspSRBHqhgC7cUDre7TZe7uAx95rj1vxCgF2XmuHRBIoji2guwQ1fZdiKhvi9E/UwgFZpfLFmO3mCUs8JJ531NzF1rnl/cVTrUYI6NbXsX8CsvFSxOT0QEOQDPSYuQ6bhEOIR1bAbsSGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766522118; c=relaxed/simple; bh=QOueJ1mRgYwmgJidNsqj0fULy188ozhjfLL7kXVZdWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RYgsW7ooYjjj6GAny4hOWkJ4zx8nA7SezHtUKKB/rRM/5itWzLvhTbK0IFXH66k3F7dGdvACMu0ZihOfR3aqmoTfj3cMfwXR+WQaEWMba1kvsk8DgCiPmiSROMUZUzdfIir3FdPh4ox+1Ru2lJ9vZpwMNo4E4NZSylYHjobCaFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EWZHdW5F; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EWZHdW5F" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7cdae63171aso1919283a34.1 for ; Tue, 23 Dec 2025 12:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766522116; x=1767126916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0uk5rbnTrDj6OgXv3yPUh1V1C8LXaBlzWsDnZOyRYEI=; b=EWZHdW5FEPVcqQmqE2ce8PDKUiN4UqEZIize/qiRSsG4jXZ2JI08qh0WNOGlcb0oTM D7PTRyUoYE5E+zCYrVuoaiQwTb7eSzqaw/7qF5NlyUysstIRJeIdgQsDdaC+pKM2oufH 6ze+/fBRM79QilA6CXFHy9Euxu16QMg8hTIRDSaFhWPKwXnY9u3UdIyeI4FTBNzxn/lr qfsnku28Gl7EMbjoWsvuXUxqzCAipHpHMmICH6r84u4jjalS7U+4FkMNB75/heMyknoQ hFEbag+Me4oNVH33WhO4p3te2Mi/xU2tQF79CugKsOGIY0CtqPRgyOJxKxxqC+crP2qy WSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766522116; x=1767126916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0uk5rbnTrDj6OgXv3yPUh1V1C8LXaBlzWsDnZOyRYEI=; b=SGV2Ak4aq8d/2kfYv8K9GiXU7MZrM7bxFu0q7fFbyagkagUcq8fMCWrEDOosW6dUdc iOSX/lnHcEyMkToOln/i8SGPneBPcqyZwsbCUbqWA8ZxJ+8l3fp1sc67I2KHxEAIn/Cc 6BiTMWw2GhQA88OiB1G7L7j1EERZMWiQId9UXCTTBkfskQ8/L4gZL15z/K7rY1zE5pjO 2XvRKaO8+v3PO95QapzVHgWBF2kQb30mvvSnf/NkuufYtwNHGpjFg5FCySX1GtL++DIO WnKjosTJHvQFuL/ABB9xP3w2rCes2sjBHKSYDQvdmTYGGBPCrqy/AmvhXc3/glwq3QU6 YoVQ== X-Forwarded-Encrypted: i=1; AJvYcCWPvU3S9loR7AQYCPJB/9k+RwMRVw7fUmHXgd+g5FlSWydxB1nDWMwa+SXDUd+qp3tLvl+H5ImP1N192m8=@vger.kernel.org X-Gm-Message-State: AOJu0YwSeMWjQHU+O8DLA0m1IL6SmDURPew2s4J3TOsa+zmuNYfdg1Va V59c2a6QHlqpRXxk04fEiGuwmBmpiPjESSfal+v2S/RKi0H0Lhq5L5Sp X-Gm-Gg: AY/fxX7/rVRvvbx2T06YaevJfAU5MZQDf+a0qpfyHDqJT8dzu4m+nbwzQJEAnv5DwTS h1Bc4+t3U7ua+8XB2IYds+o/H7nDvIvd+/dbmzUz1JIfcp5AwMKJc+Ewy9Tx75hpGtYfcq5tno4 njjFumTAo47LWJhYI/DwfrGtHNvrYjBAAV3oZq+xpbQeVWjs/lh+dTqMmElJfHCvOd+luBEDRhL MLV5zazu5tq32uZkItcFu3pp90NZhWtOGrTJYquPAYfSvm1AkIBZn7oIcTOe2d9plurlld9qcNt JnBNdlVbSfif1tURmTbdYUw41AizUUSy6pGnr7vmoO1aiMwZAOzmzU3FxODgWnjN+QdYo6UfyHB VI3eKg28H63TRuafAjoJWfZqQzSgmP87teY/dgP9pheiKPamvBVr57YWVZ95TjMODzgYbCYr3JH mXBc8qRCuJ9s9mtueyYHn9/QfhMYF2SwYoe8mul6hvvxRRMl94MBQcNFW9sYAjWVaV6RxLKq9MS FQhhsL1m1O6IkUSX5Z1KBYRwrxHq+g= X-Google-Smtp-Source: AGHT+IHyErY0P8ecU1HiiChzO9n89IIYBESftCKQJd7X7/dItVzyCNpRjo4JbYfClhw5F35/fWnswA== X-Received: by 2002:a05:6830:4103:b0:758:1417:7ee7 with SMTP id 46e09a7af769-7cc66a0b453mr8289822a34.5.1766522115974; Tue, 23 Dec 2025 12:35:15 -0800 (PST) Received: from nukework.gtech (c-98-57-15-22.hsd1.tx.comcast.net. [98.57.15.22]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc667d571dsm10065971a34.17.2025.12.23.12.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 12:35:15 -0800 (PST) From: "Alex G." To: andersson@kernel.org, Konrad Dybcio Cc: mathieu.poirier@linaro.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] remoteproc: qcom_q6v5_wcss: support m3 firmware Date: Tue, 23 Dec 2025 14:35:14 -0600 Message-ID: <5116928.iIbC2pHGDl@nukework.gtech> In-Reply-To: <5b9cd24e-7eae-4cbb-b013-6ef135902ae7@oss.qualcomm.com> References: <20251219043425.888585-1-mr.nuke.me@gmail.com> <20251219043425.888585-7-mr.nuke.me@gmail.com> <5b9cd24e-7eae-4cbb-b013-6ef135902ae7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, December 19, 2025 7:29:07 AM CST Konrad Dybcio wrote: > On 12/19/25 5:34 AM, Alexandru Gagniuc wrote: > > IPQ8074, IPQ6018, and IPQ9574 support an m3 firmware image in addtion > > to the q6 firmware. The firmware releases from qcom provide both q6 > > and m3 firmware for these SoCs. Support loading the m3 firmware image. > > > > Signed-off-by: Alexandru Gagniuc > > --- > > > > drivers/remoteproc/qcom_q6v5_wcss.c | 44 +++++++++++++++++++++++++---- > > 1 file changed, 39 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c > > b/drivers/remoteproc/qcom_q6v5_wcss.c index b62e97c92d058..265010c5c82cb > > 100644 > > --- a/drivers/remoteproc/qcom_q6v5_wcss.c > > +++ b/drivers/remoteproc/qcom_q6v5_wcss.c > > @@ -101,7 +101,8 @@ enum { > > > > }; > > > > struct wcss_data { > > > > - const char *firmware_name; > > + const char *q6_firmware_name; > > + const char *m3_firmware_name; > > > > unsigned int crash_reason_smem; > > u32 version; > > bool aon_reset_required; > > > > @@ -161,6 +162,7 @@ struct q6v5_wcss { > > > > unsigned int crash_reason_smem; > > u32 version; > > bool requires_force_stop; > > > > + const char *m3_firmware_name; > > > > struct qcom_rproc_glink glink_subdev; > > struct qcom_rproc_pdm pdm_subdev; > > > > @@ -922,11 +924,40 @@ static void *q6v5_wcss_da_to_va(struct rproc *rproc, > > u64 da, size_t len, bool *i> > > return wcss->mem_region + offset; > > > > } > > > > +static int q6v5_wcss_load_aux(struct q6v5_wcss *wcss, const char > > *fw_name) > > +{ > > + const struct firmware *extra_fw; > > + int ret; > > + > > + dev_info(wcss->dev, "loading additional firmware image %s\n", fw_name); > > I don't think this log line is useful beyond development Remoteproc driver prints the main (q6) fimrware name, so I thought it would be prudent to print the names of any additional firmwares: remoteproc remoteproc0: Booting fw image IPQ9574/q6_fw.mdt, size 8140 > > + > > + ret = request_firmware(&extra_fw, fw_name, wcss->dev); > > + if (ret) > > + return 0; > > return ret, perhaps? Unless you want to say that "it's fine if the M3 image > is missing, particularly not to impose any new requirements on existing > setups". But you haven't spelt that out explicitly. I intended to not abort when aux firmware is missing. Maybe the better way to handle this is to check for "-ENOENT" in the caller instead of return 0 here. > You also haven't provided an explanation as to why the firmware should be > loaded. Is it necessary for some functionality? Is it that case on the > newly-supported IPQ9574? I don't have a good answer. I reasoned that since the qcom provides it [1], the M3 firmware would need to be loaded. I haven't done much testing without it. Alex [1] https://github.com/quic/upstream-wifi-fw.git > Konrad