From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761150Ab3BJTrO (ORCPT ); Sun, 10 Feb 2013 14:47:14 -0500 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:55804 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754772Ab3BJTrL (ORCPT ); Sun, 10 Feb 2013 14:47:11 -0500 Message-ID: <5117F8BF.8010009@linux.vnet.ibm.com> Date: Mon, 11 Feb 2013 01:15:03 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: paulmck@linux.vnet.ibm.com CC: tglx@linutronix.de, peterz@infradead.org, tj@kernel.org, oleg@redhat.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org, rostedt@goodmis.org, wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com, rjw@sisk.pl, sbw@mit.edu, fweisbec@gmail.com, linux@arm.linux.org.uk, nikunj@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 44/45] CPU hotplug, stop_machine: Decouple CPU hotplug from stop_machine() in Kconfig References: <20130122073210.13822.50434.stgit@srivatsabhat.in.ibm.com> <20130122074518.13822.86992.stgit@srivatsabhat.in.ibm.com> <20130209001554.GR2666@linux.vnet.ibm.com> In-Reply-To: <20130209001554.GR2666@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13021019-4790-0000-0000-000006DBE65E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2013 05:45 AM, Paul E. McKenney wrote: > On Tue, Jan 22, 2013 at 01:15:22PM +0530, Srivatsa S. Bhat wrote: >> ... and also cleanup a comment that refers to CPU hotplug being dependent on >> stop_machine(). >> >> Cc: David Howells >> Signed-off-by: Srivatsa S. Bhat > > Reviewed-by: Paul E. McKenney > > (Hey, I thought I owed myself an easy one!) > Haha ;-) Regards, Srivatsa S. Bhat >> --- >> >> include/linux/stop_machine.h | 2 +- >> init/Kconfig | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h >> index 3b5e910..ce2d3c4 100644 >> --- a/include/linux/stop_machine.h >> +++ b/include/linux/stop_machine.h >> @@ -120,7 +120,7 @@ int stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); >> * @cpus: the cpus to run the @fn() on (NULL = any online cpu) >> * >> * Description: This is a special version of the above, which assumes cpus >> - * won't come or go while it's being called. Used by hotplug cpu. >> + * won't come or go while it's being called. >> */ >> int __stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); >> >> diff --git a/init/Kconfig b/init/Kconfig >> index be8b7f5..048a0c5 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -1711,7 +1711,7 @@ config INIT_ALL_POSSIBLE >> config STOP_MACHINE >> bool >> default y >> - depends on (SMP && MODULE_UNLOAD) || HOTPLUG_CPU >> + depends on (SMP && MODULE_UNLOAD) >> help >> Need stop_machine() primitive. >> >>