From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757584Ab3BKPW3 (ORCPT ); Mon, 11 Feb 2013 10:22:29 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:40880 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757255Ab3BKPW2 (ORCPT ); Mon, 11 Feb 2013 10:22:28 -0500 Message-ID: <51190CA7.7010705@ti.com> Date: Mon, 11 Feb 2013 17:22:15 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Mark Rutland CC: "tony@atomide.com" , "b-cousson@ti.com" , "balbi@ti.com" , "gregkh@linuxfoundation.org" , "stern@rowland.harvard.edu" , "linux@arm.linux.org.uk" , "kishon@ti.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 07/14] USB: ohci-omap3: Add device tree support and binding information References: <1360252974-7912-1-git-send-email-rogerq@ti.com> <1360252974-7912-8-git-send-email-rogerq@ti.com> <20130211114611.GB2726@e106331-lin.cambridge.arm.com> In-Reply-To: <20130211114611.GB2726@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2013 01:46 PM, Mark Rutland wrote: > On Thu, Feb 07, 2013 at 04:02:47PM +0000, Roger Quadros wrote: >> Allows the OHCI controller found in OMAP3 and later chips to >> be specified via device tree. >> >> Signed-off-by: Roger Quadros >> Acked-by: Alan Stern >> --- >> .../devicetree/bindings/usb/omap3-ohci.txt | 17 +++++++++++++++++ >> drivers/usb/host/ohci-omap3.c | 19 +++++++++++++++++++ >> 2 files changed, 36 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/usb/omap3-ohci.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/omap3-ohci.txt b/Documentation/devicetree/bindings/usb/omap3-ohci.txt >> new file mode 100644 >> index 0000000..ad2ace0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/omap3-ohci.txt >> @@ -0,0 +1,17 @@ >> +OMAP HS USB OHCI controller (OMAP3 and later) >> + >> +Required properties: >> + >> +- compatible: should be "ti,ohci-omap3" >> +- reg: should contain one register range i.e. start and length >> +- interrupt-parent: phandle to the interrupt controller > > I'm not sure that needs to be documented as a required property. It's a > standard property, and if it's defined for the parent node, you won't need it > here. The last time I tried without 'interrupt-parent' it complained. Doesn't do it anymore. Maybe I did something wrong the last time. I'll remove it. > > Otherwise, this looks fine to me. Thanks. I'll add your reviewed-by tag after addressing the above comment. cheers, -roger