From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Stephen Warren <swarren@nvidia.com>,
"mturquette@linaro.org" <mturquette@linaro.org>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] clk: tegra: initialise parent of uart clocks
Date: Tue, 12 Feb 2013 20:52:48 +0530 [thread overview]
Message-ID: <511A5E48.8090101@nvidia.com> (raw)
In-Reply-To: <5112964D.50707@wwwdotorg.org>
On Wednesday 06 February 2013 11:13 PM, Stephen Warren wrote:
> On 02/06/2013 03:47 AM, Laxman Dewangan wrote:
>> Initialise the parent of UARTs to PLLP
> OK
>
>> and disabling clock by default.
> Hmm. Only the clocks initialized by the new entries you added are marked
> disabled (or rather, not actively enabled; if they're enabled already,
> they won't be disabled). We should treat all UARTs equally. Historically
> we've needed to enable the serial clocks forcibly since the regular
> serial driver didn't call clk_get() or clk_prepare_enable() on any
> clocks, but I notice that it does now, since sometime in kernel 3.8. As
> such, I think you can modify all the UART entries in these tables to
> have the enable/state field set to false (0). Can you try that and check
> that it works for the serial console ports? Thanks.
Yes, this work even if I make state to 0 (disabled) in clock init table.
The of_serial driver call the clk_prepare_enable() if property
"clock_frequency" is there in dt node and in our dts file, we have
already this property.
I sent V2 patch.
next prev parent reply other threads:[~2013-02-12 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 10:47 [PATCH] clk: tegra: initialise parent of uart clocks Laxman Dewangan
2013-02-06 12:22 ` Peter De Schrijver
2013-02-06 17:37 ` Stephen Warren
2013-02-06 17:43 ` Stephen Warren
2013-02-12 15:22 ` Laxman Dewangan [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-12 15:17 Laxman Dewangan
2013-02-12 15:19 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A5E48.8090101@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pgaikwad@nvidia.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).