From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "mturquette@linaro.org" <mturquette@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V2] clk: tegra: initialise parent of uart clocks
Date: Wed, 13 Feb 2013 12:32:56 +0530 [thread overview]
Message-ID: <511B3AA0.7020403@nvidia.com> (raw)
In-Reply-To: <511A7FF1.1030009@wwwdotorg.org>
On Tuesday 12 February 2013 11:16 PM, Stephen Warren wrote:
> On 02/12/2013 08:17 AM, Laxman Dewangan wrote:
>> Initialise the parent of UARTs to PLLP and disabling clock by
>> default.
> This patch wasn't tested, was it? Without the patch I just sent titled
> "ARM: tegra: remove clock-frequency properties from serial nodes", the
> UART clocks get turned off and the console breaks.
I tested this in next-20130212 where "clock-frequency" is there in
tegra30.dtsi file.
If you remove this from dts file at all then it will not work as there
is no execution path to call the clk_prepare_enable().
of_serial.c file:
if (of_property_read_u32(np, "clock-frequency", &clk)) {
/* Get clk rate through clk driver if present */
info->clk = clk_get(&ofdev->dev, NULL);
if (IS_ERR(info->clk)) {
dev_warn(&ofdev->dev,
"clk or clock-frequency not defined\n");
return PTR_ERR(info->clk);
}
clk_prepare_enable(info->clk);
clk = clk_get_rate(info->clk);
}
next prev parent reply other threads:[~2013-02-13 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 15:17 [PATCH V2] clk: tegra: initialise parent of uart clocks Laxman Dewangan
2013-02-12 17:46 ` Stephen Warren
2013-02-12 19:34 ` Mike Turquette
2013-02-13 7:02 ` Laxman Dewangan [this message]
2013-02-13 16:34 ` Stephen Warren
2013-02-14 10:51 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B3AA0.7020403@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox