From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761575Ab3BNSyV (ORCPT ); Thu, 14 Feb 2013 13:54:21 -0500 Received: from merlin.infradead.org ([205.233.59.134]:42923 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758544Ab3BNSyU (ORCPT ); Thu, 14 Feb 2013 13:54:20 -0500 Message-ID: <511D330A.2050407@infradead.org> Date: Thu, 14 Feb 2013 10:55:06 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Shah , virtualization@lists.linux-foundation.org Subject: Re: linux-next: Tree for Feb 13 (virtio_console) References: <20130213193532.162080d7c0557a307ab451ac@canb.auug.org.au> <511BEC55.5090801@infradead.org> <87sj4zk3ai.fsf@rustcorp.com.au> <511D30B4.5020201@infradead.org> In-Reply-To: <511D30B4.5020201@infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/13 10:45, Randy Dunlap wrote: > On 02/13/13 19:00, Rusty Russell wrote: >> Randy Dunlap writes: >> >>> On 02/13/13 00:35, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20130212: >>> >>> on i386: >>> >>> drivers/built-in.o: In function `in_intr': >>> virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' >>> virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick' >>> drivers/built-in.o: In function `resize_console': >>> virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize' >>> drivers/built-in.o: In function `unplug_port': >>> virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove' >>> drivers/built-in.o: In function `init_port_console': >>> (.text+0x2fe59): undefined reference to `hvc_alloc' >>> drivers/built-in.o: In function `virtio_cons_early_init': >>> (.init.text+0x16d1): undefined reference to `hvc_instantiate' >>> >>> >>> Full randconfig file is attached. >> >> This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but >> CONFIG_HVC_DRIVER isn't set. >> >> From drivers/char/Kconfig: >> >> config VIRTIO_CONSOLE >> tristate "Virtio console" >> depends on VIRTIO >> select HVC_DRIVER >> >> ??? > > OK. It's probably yet another stinking problem with kvmtool and randconfig. > Running *config reports: > > warning: (KVMTOOL_TEST_ENABLE && LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO && TTY) > > > I'll look a bit more... Nope, that's not it. Stephen's comments were much closer. The patch below fixes the kconfig warning and the build errors. --- From: Randy Dunlap Fix kconfig warning for LGUEST_GUEST config by selecting TTY: warning: (KVMTOOL_TEST_ENABLE && LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO && TTY) Signed-off-by: Randy Dunlap --- arch/x86/lguest/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20130213.orig/arch/x86/lguest/Kconfig +++ linux-next-20130213/arch/x86/lguest/Kconfig @@ -2,6 +2,7 @@ config LGUEST_GUEST bool "Lguest guest support" select PARAVIRT depends on X86_32 + select TTY select VIRTUALIZATION select VIRTIO select VIRTIO_CONSOLE