From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761155Ab3BOPSM (ORCPT ); Fri, 15 Feb 2013 10:18:12 -0500 Received: from eu1sys200aog101.obsmtp.com ([207.126.144.111]:59379 "EHLO eu1sys200aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755696Ab3BOPSK (ORCPT ); Fri, 15 Feb 2013 10:18:10 -0500 Message-ID: <511E51A9.9020908@st.com> Date: Fri, 15 Feb 2013 16:18:01 +0100 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Christian Ruppert Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Gupta Subject: Re: [PATCH v2] Prevent interrupt loop with DWMAC MMC RX IPC Counter References: <20130215144815.GA31098@ab42.lan> <1360940282-27211-1-git-send-email-christian.ruppert@abilis.com> In-Reply-To: <1360940282-27211-1-git-send-email-christian.ruppert@abilis.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/2013 3:58 PM, Christian Ruppert wrote: > If the DesignWare MAC is synthesised with MMC RX IPC Counter, an unmanaged > and unacknowledged interrupt is generated after some time of operation. > > This patch masks the undesired interrupts. > > Signed-off-by: Christian Ruppert Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > index 0c74a70..50617c5 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c > @@ -149,6 +149,7 @@ void dwmac_mmc_intr_all_mask(void __iomem *ioaddr) > { > writel(MMC_DEFAULT_MASK, ioaddr + MMC_RX_INTR_MASK); > writel(MMC_DEFAULT_MASK, ioaddr + MMC_TX_INTR_MASK); > + writel(MMC_DEFAULT_MASK, ioaddr + MMC_RX_IPC_INTR_MASK); > } > > /* This reads the MAC core counters (if actaully supported). >