public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Sunil Beta Baskar <betasam@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix: build aborts if SPACE characters are found in path.
Date: Fri, 15 Feb 2013 16:31:03 +0100	[thread overview]
Message-ID: <511E54B7.2080709@suse.cz> (raw)
In-Reply-To: <CAK2BWApu9PjkmDdV4HoFXcq9KTh4e57iEdwYn9muVmYRwRNXgw@mail.gmail.com>

On 18.1.2013 15:33, Sunil Beta Baskar wrote:
> Signed-off-by: Sunil Beta <betasam@gmail.com>
> ---
>  Makefile |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 07bc925..48bfd8e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -10,6 +10,8 @@ NAME = "Divemaster Edition"
>  # Comments in this file are targeted only to the developer, do not
>  # expect to learn how to build the kernel reading this file.
> 
> +CURDIRSPC := $(echo $(CURDIR) | sed "s/ /\\\ /g" )
> +$(ifneq $(CURDIR),$(CURDIRSPC), $(error directory $(CURDIR) contains spaces.))

You do not need to call shell and sed here. Use the findstring make
function and the $(space) variable from scripts/Kbuild.include. Also,
while at it, could you also add a check for colon? This breaks the build
in similar way.

Thanks,
Michal

      reply	other threads:[~2013-02-15 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 14:33 [PATCH] fix: build aborts if SPACE characters are found in path Sunil Beta Baskar
2013-02-15 15:31 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511E54B7.2080709@suse.cz \
    --to=mmarek@suse.cz \
    --cc=betasam@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox