From: Chen Gang <gang.chen@asianux.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
grant.likely@secretlab.ca, linus.walleij@linaro.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Subject: [PATCH] drivers/gpio/*twl* need call irq_free_descs when leaving
Date: Sat, 16 Feb 2013 15:26:59 +0800 [thread overview]
Message-ID: <511F34C3.6020406@asianux.com> (raw)
since already call irq_alloc_descs before,
we need call irq_free_descs when quiting, or resource leak.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/gpio/gpio-twl4030.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index 4d330e3..26aef72 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -486,8 +486,10 @@ static int gpio_twl4030_probe(struct platform_device *pdev)
&irq_domain_simple_ops, NULL);
ret = twl4030_sih_setup(&pdev->dev, TWL4030_MODULE_GPIO, irq_base);
- if (ret < 0)
+ if (ret < 0) {
+ irq_free_descs(irq_base, TWL4030_GPIO_MAX);
return ret;
+ }
priv->irq_base = irq_base;
@@ -578,6 +580,7 @@ static int gpio_twl4030_remove(struct platform_device *pdev)
/* REVISIT no support yet for deregistering all the IRQs */
WARN_ON(1);
+ irq_free_descs(priv->irq_base, TWL4030_GPIO_MAX);
return -EIO;
}
--
1.7.7.6
next reply other threads:[~2013-02-16 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 7:26 Chen Gang [this message]
2013-02-18 9:09 ` [PATCH] drivers/gpio/*twl* need call irq_free_descs when leaving Peter Ujfalusi
2013-02-18 9:13 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F34C3.6020406@asianux.com \
--to=gang.chen@asianux.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox