From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BADE1D47BD for ; Tue, 14 Jan 2025 23:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897010; cv=none; b=be0W0ya3b4izoumonONdUa6kaTdTzi4iN0N4pE9TmD1tHvIm0trj87AMrgEJX9wzBP4YbPnxya8Gyf2xxsABLmtrCenenicYo2PBoXbIhfc7fO5fbQxYSW29ZyCt7ICiA7h/4BwbufxgB7Y37h3xAKvqbEYO53R4vV2KrFsGrg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897010; c=relaxed/simple; bh=9ew5fH24CfUSxClqdcqtkVOyyCGxO+Jw5+KQ5EKk750=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=qx8oVPnOotbANSd4WxmmFInD8wKHyXn1jcUcfqqXdQeTQk8mx/ibRu8OdDT2y8fB17Qe6/GKQoytUwhUv3eAL5p56nRIVCf9s28S5wILuDwspNJZbHP5HI7F+hxdyZ6guG1FaWq4x5TRhtTdzCSdle4utZrYRlMWMe7Bt6Zc+P4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=JMrfvKq+; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JMrfvKq+" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2164b662090so105500735ad.1 for ; Tue, 14 Jan 2025 15:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1736897006; x=1737501806; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=JF2SO1JNjZFS/AW+/qwVSLc3H3ROwf+oLgiJ6Im/2BQ=; b=JMrfvKq+gR+FWpFDTx8HykeWZbmj5coRigHUP1T4B0LaZkRRPrS5MefS78XVmFoUhl CJZ4YWnJfojDC4Mo6e8AxwxeKcuPdXyXbL0Z0AAKHxj0BS4TOgGfCbPdeIue5fzRtbHj s5cWV0Qs6ywV+hkwWbSoXW/H36jCL2PL6Uzr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897006; x=1737501806; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JF2SO1JNjZFS/AW+/qwVSLc3H3ROwf+oLgiJ6Im/2BQ=; b=ZPxdXfv6TABhKuHz1JMnQgs2pjmPDeclxXkg1yVZdPICLOjBuf7Q6o2ywE+L/c8stM 9gTmDJsi5vW9t39jTD5GZtoDJi5+nT0NQiCvr3iSNdPslfnBT+gIFaJF+wcbttn4xHKX joQN2gkNGTMvD3kPo403ovMPrSjKhrcgXP+GE5FY2iFWecqX4Qj/zgts0H5coYt9LVMI km/5z+Rw5Y5+SZxOW6kA0F1Wt+oN27xJ+SaPSNGentMpSpvagtiJ3iOcPGE520Elhzwu hLZF2Kijsr4VtXEpEZY7KgEmvZHgzM8hhZZGCGW/G9v7uzWtsnTaCIhoTWPf/jjlXD2H vb9g== X-Forwarded-Encrypted: i=1; AJvYcCXWQiBSv8xNKKD/W33oc3LW7vYd5DN8bGfwxe+sfT6/Ihgf56yVBDgQ1wVkVxzSseeoOMsdA36dk6ZyNQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YzYYc8IUZVmmfeJqzj7Hx/vSsJIwsxCObkY1m6BMygGXGIb4VWt l7Vi8pf5WSFbs74WKN6hmsjV6mHlfIKVgAXN1ER0otzp15ELTeMPe5wGbYCYyQ== X-Gm-Gg: ASbGnctm2mGElxtRr8HGkhfc62z6xpFBaSQxexZ1owxKAWQ0LjTCwAMcn3gzFiiyaAQ MLTSG/dNpbKQaAoA0biekcD3i/05UoiMsA1iJ7Gygyqc2vWcRrftz3h5ZteOiQF3yXoQKsFAZB7 ZQBMvLij8R4ttWPXuFokX64c8qRMFuTVCjfV8t98H/1rd5p5hamNTddpuGGzRv3KU5o7kV3ixTq TffKKc9GSvGv+EZFFdnNZll7ACHh2s/V+VU5VbExXKtjMVmFQAv9iGraRdi+eWpDiNCug6QIU0h pm4nIq1r7zv8f60smt7r9bMD8bqaqtg= X-Google-Smtp-Source: AGHT+IFP+iDz9d53FNYprYxDfsZHKpRDF3bHc76kCec6tsY8vy4yCwcxXTB9ww6UWz6UHEjmZYk7/w== X-Received: by 2002:a17:903:244c:b0:216:725c:a137 with SMTP id d9443c01a7336-21a83f72472mr455838475ad.28.1736897006461; Tue, 14 Jan 2025 15:23:26 -0800 (PST) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f22dd30sm72193155ad.171.2025.01.14.15.23.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 15:23:25 -0800 (PST) Message-ID: <511eb6d3-ff74-43e8-ad27-808ecb53e698@broadcom.com> Date: Tue, 14 Jan 2025 15:23:23 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: Use str_enable_disable-like helpers To: Krzysztof Kozlowski , Vinod Koul , Kishon Vijay Abraham I , Ray Jui , Scott Branden , Broadcom internal kernel review list , Laurent Pinchart , Michal Simek , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250114203537.1012955-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250114203537.1012955-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/2025 12:35 PM, Krzysztof Kozlowski wrote: > Replace ternary (condition ? "enable" : "disable") syntax with helpers > from string_choices.h because: > 1. Simple function call with one argument is easier to read. Ternary > operator has three arguments and with wrapping might lead to quite > long code. > 2. Is slightly shorter thus also easier to read. > 3. It brings uniformity in the text - same string. > 4. Allows deduping by the linker, which results in a smaller binary > file. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Florian Fainelli -- Florian