From: Pavel Emelyanov <xemul@parallels.com>
To: Jann Horn <jannhorn@googlemail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-api@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] posix timers: Add syscall that works on timer sigevent
Date: Sun, 17 Feb 2013 22:53:40 +0400 [thread overview]
Message-ID: <51212734.2060700@parallels.com> (raw)
In-Reply-To: <20130217134248.GD13378@debjann.fritz.box>
On 02/17/2013 05:42 PM, Jann Horn wrote:
> On Thu, Feb 14, 2013 at 08:19:45PM +0400, Pavel Emelyanov wrote:
>> + struct sigevent event;
> [...]
>> + event.sigev_notify = timer->it_sigev_notify;
>> + event.sigev_signo = timer->sigq->info.si_signo;
>> + event.sigev_value = timer->sigq->info.si_value;
>> + event.sigev_notify_thread_id = pid_vnr(timer->it_pid);
> [...]
>> + if (old_event && copy_to_user(old_event, &event, sizeof(event)))
>
> Won't this leak uninitialized kernel stack data to userspace? As far as I can
> see, the _sigev_un union is bigger than the _tid field in it, so the rest of
> it will be copied over without initialization, right?
Indeed :( Thanks for catching this, I will memezro the thing before copying
to the user-space.
> Jann
>
next prev parent reply other threads:[~2013-02-17 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 16:18 [PATCH 0/3] posix timers: Extend kernel API to report more info about timers Pavel Emelyanov
2013-02-14 16:19 ` [PATCH 1/3] posix timers: Allocate timer id per process Pavel Emelyanov
2013-02-14 20:13 ` Sasha Levin
2013-02-15 5:13 ` Pavel Emelyanov
2013-02-14 16:19 ` [PATCH 2/3] posix timers: Add syscall that lists timer IDs armed by process Pavel Emelyanov
2013-02-14 16:19 ` [PATCH 3/3] posix timers: Add syscall that works on timer sigevent Pavel Emelyanov
2013-02-17 13:42 ` Jann Horn
2013-02-17 18:53 ` Pavel Emelyanov [this message]
2013-02-21 1:21 ` [PATCH 0/3] posix timers: Extend kernel API to report more info about timers Matthew Helsley
2013-02-21 10:35 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51212734.2060700@parallels.com \
--to=xemul@parallels.com \
--cc=jannhorn@googlemail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox