From: Len Brown <lenb@kernel.org>
To: Benson Leung <bleung@chromium.org>
Cc: colin.king@canonical.com, linux-kernel@vger.kernel.org,
vapier@gentoo.org
Subject: Re: [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686
Date: Mon, 18 Feb 2013 00:06:17 -0500 [thread overview]
Message-ID: <5121B6C9.70001@kernel.org> (raw)
In-Reply-To: <1360870558-11711-2-git-send-email-bleung@chromium.org>
Hi Benson,
checkpatch.pl doesn't love this syntax:
ERROR: spaces required around that ':' (ctx:ExV)
#113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142:
+ :"+a" (_eax), "=S" (_ebx), "=c" (_ecx), "=d" (_edx)
^
ERROR: spaces required around that ':' (ctx:ExV)
#115: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:144:
+ :"edi" /* clobbers: we hit edi directly */);
^
ERROR: trailing statements should be on next line
#116: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:145:
+ if (eax) *eax = _eax;
ERROR: trailing statements should be on next line
#117: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:146:
+ if (ebx) *ebx = _ebx;
ERROR: trailing statements should be on next line
#118: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:147:
+ if (ecx) *ecx = _ecx;
ERROR: trailing statements should be on next line
#119: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:148:
+ if (edx) *edx = _edx;
total: 6 errors, 2 warnings, 57 lines checked
/home/lenb/Documents/epp.eml has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Commit Body is:
--------------------------
tools/power x86_energy_perf_policy: fix cpuid for i686
next prev parent reply other threads:[~2013-02-18 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 19:35 [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686 Benson Leung
2013-02-14 19:35 ` Benson Leung
2013-02-18 5:06 ` Len Brown [this message]
2013-02-18 5:17 ` Mike Frysinger
2013-02-19 20:18 ` [PATCH v4 0/1] " Benson Leung
2013-02-19 20:18 ` [PATCH v4 1/1] " Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5121B6C9.70001@kernel.org \
--to=lenb@kernel.org \
--cc=bleung@chromium.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox