From: Chen Gang <gang.chen@asianux.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: grant.likely@secretlab.ca, linus.walleij@linaro.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] drivers/gpio/*twl* need call irq_free_descs when leaving
Date: Mon, 18 Feb 2013 17:13:30 +0800 [thread overview]
Message-ID: <5121F0BA.2080103@asianux.com> (raw)
In-Reply-To: <5121EFE7.7040301@ti.com>
于 2013年02月18日 17:09, Peter Ujfalusi 写道:
> On 02/16/2013 08:26 AM, Chen Gang wrote:
>> >
>> > since already call irq_alloc_descs before,
>> > we need call irq_free_descs when quiting, or resource leak.
> While it is true that we need to free the descs, but this patch is not correct.
> We have other issues to fix in the driver - I have not looked at the
> probe/remove path yet, but the sequence is not right and also the call of
> gpio_twl4030_remove() from probe is not correct.
>
> I'll send a small series to fix these up.
>
ok, thank you.
:-)
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-02-18 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 7:26 [PATCH] drivers/gpio/*twl* need call irq_free_descs when leaving Chen Gang
2013-02-18 9:09 ` Peter Ujfalusi
2013-02-18 9:13 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5121F0BA.2080103@asianux.com \
--to=gang.chen@asianux.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox