* [PATCH] backlight: adp8860/adp8870: Fix resume
@ 2013-02-19 13:02 Lars-Peter Clausen
2013-02-19 13:09 ` Michael Hennerich
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-02-19 13:02 UTC (permalink / raw)
To: Andrew Morton
Cc: Richard Purdie, Michael Hennerich, device-drivers-devel,
linux-kernel, Lars-Peter Clausen
Clearing the NSTBY bit in the control register also automatically clears the
BLEN bit. So we need to make sure to set it again during resume, otherwise the
backlight will stay off.
Cc: stable@vger.kernel.org
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/video/backlight/adp8860_bl.c | 2 +-
drivers/video/backlight/adp8870_bl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 6bb72c0..a77c9ca 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -783,7 +783,7 @@ static int adp8860_i2c_suspend(struct i2c_client *client, pm_message_t message)
static int adp8860_i2c_resume(struct i2c_client *client)
{
- adp8860_set_bits(client, ADP8860_MDCR, NSTBY);
+ adp8860_set_bits(client, ADP8860_MDCR, NSTBY | BLEN);
return 0;
}
diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
index 63c882b..712c25a 100644
--- a/drivers/video/backlight/adp8870_bl.c
+++ b/drivers/video/backlight/adp8870_bl.c
@@ -957,7 +957,7 @@ static int adp8870_i2c_suspend(struct i2c_client *client, pm_message_t message)
static int adp8870_i2c_resume(struct i2c_client *client)
{
- adp8870_set_bits(client, ADP8870_MDCR, NSTBY);
+ adp8870_set_bits(client, ADP8870_MDCR, NSTBY | BLEN);
return 0;
}
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] backlight: adp8860/adp8870: Fix resume
2013-02-19 13:02 [PATCH] backlight: adp8860/adp8870: Fix resume Lars-Peter Clausen
@ 2013-02-19 13:09 ` Michael Hennerich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Hennerich @ 2013-02-19 13:09 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Andrew Morton, Richard Purdie,
device-drivers-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org
On 02/19/2013 02:02 PM, Lars-Peter Clausen wrote:
> Clearing the NSTBY bit in the control register also automatically clears the
> BLEN bit. So we need to make sure to set it again during resume, otherwise the
> backlight will stay off.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/video/backlight/adp8860_bl.c | 2 +-
> drivers/video/backlight/adp8870_bl.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 6bb72c0..a77c9ca 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -783,7 +783,7 @@ static int adp8860_i2c_suspend(struct i2c_client *client, pm_message_t message)
>
> static int adp8860_i2c_resume(struct i2c_client *client)
> {
> - adp8860_set_bits(client, ADP8860_MDCR, NSTBY);
> + adp8860_set_bits(client, ADP8860_MDCR, NSTBY | BLEN);
>
> return 0;
> }
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 63c882b..712c25a 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -957,7 +957,7 @@ static int adp8870_i2c_suspend(struct i2c_client *client, pm_message_t message)
>
> static int adp8870_i2c_resume(struct i2c_client *client)
> {
> - adp8870_set_bits(client, ADP8870_MDCR, NSTBY);
> + adp8870_set_bits(client, ADP8870_MDCR, NSTBY | BLEN);
>
> return 0;
> }
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-19 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 13:02 [PATCH] backlight: adp8860/adp8870: Fix resume Lars-Peter Clausen
2013-02-19 13:09 ` Michael Hennerich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox