From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 1/4] [media] ad5820: Define entity function
Date: Thu, 20 Sep 2018 23:22:55 +0300 [thread overview]
Message-ID: <512495074.bF91m146Of@avalon> (raw)
In-Reply-To: <20180920161912.17063-1-ricardo.ribalda@gmail.com>
Hi Ricardo,
Thank you for the patch.
On Thursday, 20 September 2018 19:19:09 EEST Ricardo Ribalda Delgado wrote:
> Without this patch, media_device_register_entity throws a warning:
>
> dev_warn(mdev->dev,
> "Entity type for entity %s was not initialized!\n",
> entity->name);
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/ad5820.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
> index 907323f0ca3b..22759aaa2dba 100644
> --- a/drivers/media/i2c/ad5820.c
> +++ b/drivers/media/i2c/ad5820.c
> @@ -317,6 +317,7 @@ static int ad5820_probe(struct i2c_client *client,
> v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops);
> coil->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> coil->subdev.internal_ops = &ad5820_internal_ops;
> + coil->subdev.entity.function = MEDIA_ENT_F_LENS;
> strscpy(coil->subdev.name, "ad5820 focus", sizeof(coil->subdev.name));
>
> ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL);
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2018-09-20 20:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 16:19 [PATCH 1/4] [media] ad5820: Define entity function Ricardo Ribalda Delgado
2018-09-20 16:19 ` [PATCH 2/4] [media] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2018-09-20 18:40 ` Sakari Ailus
2018-09-20 18:47 ` Ricardo Ribalda Delgado
2018-09-20 18:45 ` [PATCH v2 " Ricardo Ribalda Delgado
2018-09-20 18:54 ` Pavel Machek
2018-09-20 19:06 ` Ricardo Ribalda Delgado
2018-09-20 19:08 ` Pavel Machek
2018-09-20 19:12 ` Ricardo Ribalda Delgado
2018-09-20 20:04 ` Laurent Pinchart
2018-09-20 20:04 ` Laurent Pinchart
2018-09-20 20:14 ` Pavel Machek
2018-09-20 20:21 ` Pavel Machek
2018-09-20 20:32 ` Ricardo Ribalda Delgado
2018-09-20 16:19 ` [PATCH 3/4] [media] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2018-09-20 20:21 ` Laurent Pinchart
2018-09-20 20:23 ` Laurent Pinchart
2018-09-20 20:25 ` Ricardo Ribalda Delgado
2018-09-20 20:28 ` Pavel Machek
2018-09-20 16:19 ` [PATCH 4/4] [media] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2018-09-20 18:31 ` [PATCH v2 " Ricardo Ribalda Delgado
2018-09-20 18:55 ` Pavel Machek
2018-09-20 20:10 ` Laurent Pinchart
2018-09-20 20:18 ` Sakari Ailus
2018-09-20 20:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512495074.bF91m146Of@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=ricardo.ribalda@gmail.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox