The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: <containers@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Steffen Michalke <StMichalke@web.de>
Subject: Re: PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set
Date: Thu, 21 Feb 2013 19:44:30 +0400	[thread overview]
Message-ID: <512640DE.4050201@parallels.com> (raw)
In-Reply-To: <51260390.8010203@parallels.com>

On 02/21/2013 03:22 PM, Glauber Costa wrote:
> On 02/21/2013 03:00 AM, Tejun Heo wrote:
>> (cc'ing cgroup / memcg people and quoting whole body)
>>
>> Looks like something is going wrong with memcg cache destruction.
>> Glauber, any ideas?  Also, can we please not use names as generic as
>> kmem_cache_destroy_work_func for something specific to memcg?  How
>> about something like memcg_destroy_cache_workfn?
>>
>> Thanks.
> 
> Steffen,
> 
> Is there any chance you could test that using SLAB instead of SLUB?
> I haven't manage to reproduce it yet, but I am working on some theories
> about why this is happening. If I could at least know if this is likely
> a cache problem vs a inner-memcg problem, that would help. The calltrace
> is not incredibly helpful, but it does indicate that the problem happens
> when freeing cache objects.
> 

Update:

I've already reproduced this and determined this is a problem that
plagues slub only, most likely due to initialization of the node caches.
But I still don't know for sure the exact location. Expect a patch by
tomorrow.


      reply	other threads:[~2013-02-21 15:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-20 15:49 PROBLEM: Crash cgdeleting empty memory cgroups with memory.kmem.limit_in_bytes set Steffen Michalke
2013-02-20 23:00 ` Tejun Heo
2013-02-21  8:34   ` Glauber Costa
2013-02-22  3:15     ` Kamezawa Hiroyuki
2013-02-21 11:22   ` Glauber Costa
2013-02-21 15:44     ` Glauber Costa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512640DE.4050201@parallels.com \
    --to=glommer@parallels.com \
    --cc=StMichalke@web.de \
    --cc=containers@lists.linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox