From: Stephen Boyd <sboyd@codeaurora.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: mmotm 2013-02-19-17-20 uploaded
Date: Thu, 21 Feb 2013 11:31:50 -0800 [thread overview]
Message-ID: <51267626.3030308@codeaurora.org> (raw)
In-Reply-To: <512668FA.5040505@sgi.com>
On 2/21/2013 10:35 AM, Nathan Zimmer wrote:
>
>> This comment is useful around the cpumask functions.
>>
>> Returns >= nr_cpu_ids if no further cpus set.
>>
> I had assumed it would be = nr_cpu_ids.
> I will need to rethink the iterator.
Yes it is actually equal to the nr_cpu_ids in my error case. On my
system, nr_cpu_ids = 4 and I only have one cpu online.
>
>
> Also I retested my other patches in the series, the ones for schedstat
> and sched_debug, and those worked fine.
I haven't tried those yet. I will try to take a look.
Also, can't we simplify the code by calling cpumask_next() with the
first argument being -1? No more cpu > 0 check?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-02-21 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 1:21 mmotm 2013-02-19-17-20 uploaded akpm
2013-02-20 16:41 ` since-3.8 branch opened for mm git tree (was: mmotm 2013-02-19-17-20 uploaded) Michal Hocko
2013-02-21 9:25 ` mmotm 2013-02-19-17-20 uploaded Stephen Boyd
2013-02-21 18:18 ` Nathan Zimmer
2013-02-21 18:27 ` Stephen Boyd
2013-02-21 18:35 ` Nathan Zimmer
2013-02-21 19:31 ` Stephen Boyd [this message]
2013-02-26 23:33 ` [PATCH v3 0/2] timer_list: Fix /proc/timer_list failure on 4096 cpus Nathan Zimmer
2013-02-26 23:33 ` [PATCH v3 1/2] timer_list: split timer_list_show_tickdevices() Nathan Zimmer
2013-02-27 19:37 ` Stephen Boyd
2013-02-27 19:56 ` Nathan Zimmer
2013-02-28 1:05 ` Nathan Zimmer
2013-02-26 23:33 ` [PATCH v3 2/2] timer_list: convert timer list to be a proper seq_file Nathan Zimmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51267626.3030308@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=nzimmer@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox