From: leroy christophe <christophe.leroy@c-s.fr>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Unset LANG in setlocalversion script
Date: Fri, 22 Feb 2013 09:56:30 +0100 [thread overview]
Message-ID: <512732BE.60503@c-s.fr> (raw)
In-Reply-To: <51268E25.6070104@suse.cz>
Le 21/02/2013 22:14, Michal Marek a écrit :
> Dne 21.2.2013 13:49, Christophe Leroy napsal(a):
>> This patch allows the use of setlocalversion script regardless of the LANG
>> parameter. Otherwise, the `svn info 2>/dev/null | grep '^Last Changed Rev'`
>> returns nothing because for instance, in French the text 'Last Changed Rev'
>> is replaced by 'Révision de la derničre modification'
> Unsetting LANG might not be enough. You should unset LC_ALL and set
> LC_MESSAGES=C. But - is this a problem for other commands in the script?
> From a quick look, we only parse English output of svn, so I suggest to
> only set the env var for the svn command.
>
> Michal
>
Ok, I will propose a new patch.
I confirm my only issue at the time being is with the svn command.
Christophe
prev parent reply other threads:[~2013-02-22 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 12:49 [PATCH] Unset LANG in setlocalversion script Christophe Leroy
2013-02-21 21:14 ` Michal Marek
2013-02-22 8:56 ` leroy christophe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512732BE.60503@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox