From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756991Ab3BVTve (ORCPT ); Fri, 22 Feb 2013 14:51:34 -0500 Received: from [89.21.227.133] ([89.21.227.133]:32241 "EHLO mail.kdh.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756892Ab3BVTva (ORCPT ); Fri, 22 Feb 2013 14:51:30 -0500 Message-ID: <5127CC40.6070507@itdev.co.uk> Date: Fri, 22 Feb 2013 19:51:28 +0000 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Benson Leung CC: Dmitry Torokhov , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , "Bowens, Alan" , linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , Peter Meerwald , Olof Johansson , Yufeng Shen Subject: Re: [PATCH 11/40] Input: atmel_mxt_ts - Bootloader addresses for mXT1664/mXT1188S References: <1361555907-19840-1-git-send-email-nick.dyer@itdev.co.uk> <1361555907-19840-12-git-send-email-nick.dyer@itdev.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benson Leung wrote: > This is disappointing that Atmel decided to change the bootloader > address scheme for the 1664S family. Unfortunately, this ifdef won't > work for situations where there are more than one Atmel device of a > different kind on a system using this same driver. > > For the Chromebook Pixel, we use the same atmel_mxt_ts driver for a > 1664S device and a 224SL. > > The 1664S has the pair 0x26 and 0x4a, while the 224SL has 0x25 and > 0x4b. If I put a bootloader address override in the platform data will that meet your requirements?