From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3F6C43334 for ; Thu, 21 Jul 2022 07:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232378AbiGUHJW (ORCPT ); Thu, 21 Jul 2022 03:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232433AbiGUHJO (ORCPT ); Thu, 21 Jul 2022 03:09:14 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F36B7B1DA for ; Thu, 21 Jul 2022 00:09:13 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id h8so929012wrw.1 for ; Thu, 21 Jul 2022 00:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=VE0LYpBcSNLxgeKI7cPWq0L3IMO+8/VrqV7u3JYjwXE=; b=eK/pGzO2n6WNLTNZO3Wd0ggPr4sppqc2TD1nUpb+tDhAms8nFEZmQmVFrA8jRCR0P5 RQCYcp5aPDhe4Ekv+Lv8FD11jDbxoRwd05zIYzhlt7yLNrV+/NhG9E3yE8RJHB/bxjnM 4E/StMXj5w3VQx90jWR2MAhjCT0foKvDnbKnDqIpWbXqto5ydoWY2r1OK49Zvi/DcjgA iwNo+ZBB+irKddepVl6RDPPWQQgFki1PFY48YaB5vLMSIhBRgd2F4/f100YkJPdWl7rl y1IGSd16N8ZPpZJFK5k08dE8pzL+KpTAY5apyN4946Tp755UiGjLWZ5HSYM7EH7AXT7q 6PxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:organization :in-reply-to:content-transfer-encoding; bh=VE0LYpBcSNLxgeKI7cPWq0L3IMO+8/VrqV7u3JYjwXE=; b=37CQVhH7NRCuhmng/2vf0h0YQxoT8d6AKyzzGJ9ON90xmV/zjKX+Z4CZNqGrDslUkP m12ov7g3WBXUIjhAR1dUioB4EJm8IHBo+sPB6jZQjjH/DU8gitkXmEV0NVt44W7+Isvy SSOvyjbmZvbDwNCuemQbcxF/msnx/5jJ63CLpfmkPn5YDn/MGasly8vf41qD6IHXK9aA hfPWnhDDvj++qlupSnWG2tQ+vUtRyXDy27KiaxF0VAwQPm0anstC1yp9B4o0BEAcTjLL gYQK5NSy8VzEK5Iw9rdJ8kEjzOE1h4etur2MacquJ/ZkQgMO4zrXdvm3QbMuVBWbc+C5 70Zg== X-Gm-Message-State: AJIora/djQUHq5v9gNfIrMIr7bYUjp5HHu8PLaK+/oyPAXlSkTInoYok iYdpZ+zYFSp9LJfEczP4E6MwNQ== X-Google-Smtp-Source: AGRyM1vpOKAfATUcM8qlCM2ouUnThntzP+VxAoH0+K3O4DTe/+n6mZSxk9Ee/fycS5xGUIXpJpfSxQ== X-Received: by 2002:a5d:4c4d:0:b0:21d:866e:4739 with SMTP id n13-20020a5d4c4d000000b0021d866e4739mr32190232wrt.147.1658387351367; Thu, 21 Jul 2022 00:09:11 -0700 (PDT) Received: from ?IPV6:2a01:e0a:b41:c160:956c:3203:b371:1705? ([2a01:e0a:b41:c160:956c:3203:b371:1705]) by smtp.gmail.com with ESMTPSA id t7-20020a05600c198700b003a30af0ec83sm2665435wmq.25.2022.07.21.00.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 00:09:10 -0700 (PDT) Message-ID: <5128cc99-121c-843d-8a65-a930bfb6fa79@6wind.com> Date: Thu, 21 Jul 2022 09:09:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH v2 net-next] net: ipv6: avoid accepting values greater than 2 for accept_untracked_na Content-Language: en-US To: Jaehee Park , netdev@vger.kernel.org Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, dsahern@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org, linux-kernel@vger.kernel.org, aajith@arista.com, roopa@nvidia.com, roopa.prabhu@gmail.com, aroulin@nvidia.com, sbrivio@redhat.com References: <20220720183632.376138-1-jhpark1013@gmail.com> From: Nicolas Dichtel Organization: 6WIND In-Reply-To: <20220720183632.376138-1-jhpark1013@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 20/07/2022 à 20:36, Jaehee Park a écrit : > The accept_untracked_na sysctl changed from a boolean to an integer > when a new knob '2' was added. This patch provides a safeguard to avoid > accepting values that are not defined in the sysctl. When setting a > value greater than 2, the user will get an 'invalid argument' warning. > > Signed-off-by: Jaehee Park > Suggested-by: Nicolas Dichtel > Suggested-by: Roopa Prabhu Reviewed-by: Nicolas Dichtel