Re: [PATCH 2/3] cgroup: add cgroup_name() API

Li Zefan
2013-02-27T10:50:38Z

On 2013/2/26 21:26, Tejun Heo wrote:
> Hello,
>
> On Tue, Feb 26, 2013 at 2:25 AM, Li Zefan <lizefan@huawei.com> wrote:
>> Sure we can. We'll have to allocate cgrp->name in cgroup_remount() and
>> cgroup_init(), and free cgrp->name in cgroup_kill_sb(). It looks to me
>> the current version is a bit simpler.
>
> Can't we just set it to constant "/"? Root cgroup init is a separate
> path anyway.
>

Well, cgrp->name is a pointer to struct cgroup_name.

At first I tried to declare cgrp->name as char *, and use container_of()
to get struct cgroup_name, but it didn't result in simpler code.

So seems there's no way that is a pure win over another.