* [PATCH] vme: add missing put_device() after device_register() fails
@ 2013-02-13 18:47 Emilio G. Cota
2013-02-25 15:35 ` Martyn Welch
0 siblings, 1 reply; 2+ messages in thread
From: Emilio G. Cota @ 2013-02-13 18:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Martyn Welch, Manohar Vanga, Emilio G. Cota, devel, linux-kernel
From: "Emilio G. Cota" <cota@braap.org>
put_device() must be called after device_register() fails,
since device_register() always initializes the refcount
on the device structure.
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
drivers/vme/vme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 95a9f71..5e6c7d7 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1366,26 +1366,27 @@ static int __vme_register_driver_bus(struct vme_driver *drv,
err = device_register(&vdev->dev);
if (err)
goto err_reg;
if (vdev->dev.platform_data) {
list_add_tail(&vdev->drv_list, &drv->devices);
list_add_tail(&vdev->bridge_list, &bridge->devices);
} else
device_unregister(&vdev->dev);
}
return 0;
err_reg:
+ put_device(&vdev->dev);
kfree(vdev);
err_devalloc:
list_for_each_entry_safe(vdev, tmp, &drv->devices, drv_list) {
list_del(&vdev->drv_list);
list_del(&vdev->bridge_list);
device_unregister(&vdev->dev);
}
return err;
}
static int __vme_register_driver(struct vme_driver *drv, unsigned int ndevs)
{
struct vme_bridge *bridge;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vme: add missing put_device() after device_register() fails
2013-02-13 18:47 [PATCH] vme: add missing put_device() after device_register() fails Emilio G. Cota
@ 2013-02-25 15:35 ` Martyn Welch
0 siblings, 0 replies; 2+ messages in thread
From: Martyn Welch @ 2013-02-25 15:35 UTC (permalink / raw)
To: Emilio G. Cota; +Cc: Greg Kroah-Hartman, Manohar Vanga, devel, linux-kernel
On 13/02/13 18:47, Emilio G. Cota wrote:
> From: "Emilio G. Cota" <cota@braap.org>
>
> put_device() must be called after device_register() fails,
> since device_register() always initializes the refcount
> on the device structure.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> drivers/vme/vme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
> index 95a9f71..5e6c7d7 100644
> --- a/drivers/vme/vme.c
> +++ b/drivers/vme/vme.c
> @@ -1366,26 +1366,27 @@ static int __vme_register_driver_bus(struct vme_driver *drv,
> err = device_register(&vdev->dev);
> if (err)
> goto err_reg;
>
> if (vdev->dev.platform_data) {
> list_add_tail(&vdev->drv_list, &drv->devices);
> list_add_tail(&vdev->bridge_list, &bridge->devices);
> } else
> device_unregister(&vdev->dev);
> }
> return 0;
>
> err_reg:
> + put_device(&vdev->dev);
> kfree(vdev);
> err_devalloc:
> list_for_each_entry_safe(vdev, tmp, &drv->devices, drv_list) {
> list_del(&vdev->drv_list);
> list_del(&vdev->bridge_list);
> device_unregister(&vdev->dev);
> }
> return err;
> }
Acked-by: Martyn Welch <martyn.welch@ge.com>
(Sorry it took me so long to respond)
>
> static int __vme_register_driver(struct vme_driver *drv, unsigned int ndevs)
> {
> struct vme_bridge *bridge;
>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-25 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-13 18:47 [PATCH] vme: add missing put_device() after device_register() fails Emilio G. Cota
2013-02-25 15:35 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox