public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/5] perf tools: Fix -C option for record command
Date: Mon, 25 Feb 2013 11:56:38 -0700	[thread overview]
Message-ID: <512BB3E6.6000904@gmail.com> (raw)
In-Reply-To: <20130225183932.GA7352@redhat.com>

On 2/25/13 11:39 AM, Oleg Nesterov wrote:
> To clarify, I am not trying to review this patch, I'd like to ask
> the question...
>
> On 02/25, Jiri Olsa wrote:
>>
>> Currently the -C option does not work for record command,
>> because of the targets mismatch when synthesizing threads.
>>
>> Fixing this by using proper target interface for the
>> synthesize decision.
>
> OK, but my fix had the different goal. I thought that
>
> 	$ perf ... record -C0 sleep 1
>
> should attach the counter to the child process (workload) and set
> event->cpu = 0 (instead of -1). With this patch we create the cpu

If a target is given (-a, -C, -p or -t) that is what the data is 
collected for -- all cpus, a cpu, or one or more task ids. The workload 
in that case becomes a means for bounding the data collection (start and 
end points).

If you want to collect events for a workload you just run perf-record -- 
workload.

Last time I dug into it (which was 8-12 months ago) -C required -a to 
work properly. -a (system_wide) meaning collect events for all cpus and 
then -C meaning but only for this cpu. Perhaps Namyhung's target changes 
may have simplified fixing that as Jiri's patch suggests.

David

  reply	other threads:[~2013-02-25 18:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25  9:52 [PATCH 0/5] perf tools: Fix -C option for record command Jiri Olsa
2013-02-25  9:52 ` [PATCH 1/5] " Jiri Olsa
2013-02-25 18:39   ` Oleg Nesterov
2013-02-25 18:56     ` David Ahern [this message]
2013-02-25 19:38       ` Jiri Olsa
2013-02-26 14:38         ` Oleg Nesterov
2013-03-18 10:53   ` [tip:perf/urgent] perf record: Fix -C option tip-bot for Jiri Olsa
2013-02-25  9:52 ` [PATCH 2/5] perf tests: Make attr script verbose friendly Jiri Olsa
2013-03-21 10:54   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25  9:52 ` [PATCH 3/5] perf tests: Make attr script test event cpu Jiri Olsa
2013-03-21 10:55   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25  9:52 ` [PATCH 4/5] perf tests: Add attr record -C cpu test Jiri Olsa
2013-03-21 10:57   ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-02-25  9:52 ` [PATCH 5/5] perf tests: Add attr stat " Jiri Olsa
2013-03-21 10:58   ` [tip:perf/core] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512BB3E6.6000904@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox