From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <linux-efi@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH] x86, efi: Mark disable_runtime as __initdata
Date: Tue, 26 Feb 2013 08:55:06 +0900 [thread overview]
Message-ID: <512BF9DA.2050906@jp.fujitsu.com> (raw)
In-Reply-To: <1361545427-26393-1-git-send-email-matt@console-pimps.org>
(2013/02/23 0:03), Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> disable_runtime is only referenced from __init functions, so mark it
> as __initdata.
>
> Reported-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
It looks good to me.
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> ---
> arch/x86/platform/efi/efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 2f81db4..5ae99f9 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -85,7 +85,7 @@ int efi_enabled(int facility)
> }
> EXPORT_SYMBOL(efi_enabled);
>
> -static bool disable_runtime = false;
> +static bool __initdata disable_runtime = false;
> static int __init setup_noefi(char *arg)
> {
> disable_runtime = true;
>
next prev parent reply other threads:[~2013-02-25 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 15:03 [PATCH] x86, efi: Mark disable_runtime as __initdata Matt Fleming
2013-02-25 23:55 ` Satoru Takeuchi [this message]
2013-02-26 0:22 ` [tip:x86/urgent] " tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512BF9DA.2050906@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=hpa@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox