From: Tang Chen <tangchen@cn.fujitsu.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Martin Bligh <mbligh@mbligh.org>, Ingo Molnar <mingo@elte.hu>,
Don Morris <don.morris@hp.com>, "H. Peter Anvin" <hpa@zytor.com>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tim Gardner <tim.gardner@canonical.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, a.p.zijlstra@chello.nl,
jarkko.sakkinen@intel.com
Subject: Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!
Date: Tue, 26 Feb 2013 15:29:38 +0800 [thread overview]
Message-ID: <512C6462.3030602@cn.fujitsu.com> (raw)
In-Reply-To: <CAE9FiQVsmt4jhR=+Uyg+Cbh2AEF9-gAdoPiJrM8itaLCsAOKcA@mail.gmail.com>
On 02/26/2013 02:57 PM, Yinghai Lu wrote:
> That is temporary workaround and your patch and this workaround make
> x86 acpi numa init too messy.
>
> I don't see the point to hack SRAT to make memory hotplug working.
>
> Do you guys check and use PMTT in ACPI spec instead?
Hi Yinghai,
Thanks for the suggestion. :)
The point we are using SRAT is that we need the hot-pluggable bit in SRAT.
I didn't find such info in PMTT or elsewhere.
We use SRAT in this way aims to satisfy users who don't want to specify
physical address ranges in kernel command line. They want to use SRAT to
determine which memory is hot-pluggable, and which is not.
To achieve this aim, we have to ensure we have the SRAT info before
memblock
starts to allocate memory. So that we can prevent memblock from allocating
memory in the hot-pluggable area. So I have to parse SRAT earlier.
I don't think the code is that messy. I think we can encapsulate the clear
up job into one function, and call it where it is needed.
How do you think ?
Thanks. :)
next prev parent reply other threads:[~2013-02-26 7:30 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 15:02 sched: CPU #1's llc-sibling CPU #0 is not on the same node! Tim Gardner
2013-02-25 15:32 ` Tim Gardner
2013-02-25 21:27 ` Don Morris
2013-02-25 22:50 ` Yinghai Lu
2013-02-26 0:35 ` Yinghai Lu
2013-02-26 2:06 ` Yinghai Lu
2013-02-26 3:21 ` Martin Bligh
2013-02-26 4:20 ` Yinghai Lu
2013-02-26 4:51 ` Martin Bligh
2013-02-26 6:09 ` Tang Chen
2013-02-26 6:57 ` Yinghai Lu
2013-02-26 7:29 ` Tang Chen [this message]
2013-02-26 7:53 ` Yasuaki Ishimatsu
2013-03-01 6:37 ` H. Peter Anvin
2013-03-01 8:05 ` Yinghai Lu
2013-03-01 10:59 ` Ingo Molnar
2013-03-01 11:03 ` Borislav Petkov
2013-03-01 11:24 ` Ingo Molnar
2013-03-01 15:32 ` H. Peter Anvin
2013-02-26 1:51 ` Tang Chen
2013-02-26 21:36 ` Yinghai Lu
2013-02-26 22:44 ` Yinghai Lu
2013-02-27 0:52 ` Yasuaki Ishimatsu
2013-02-27 2:30 ` Yinghai Lu
2013-02-27 3:38 ` Yasuaki Ishimatsu
2013-02-27 4:04 ` Yinghai Lu
2013-02-27 4:43 ` Yasuaki Ishimatsu
2013-02-27 5:11 ` Yinghai Lu
2013-02-27 5:49 ` Yasuaki Ishimatsu
2013-02-27 6:54 ` Yinghai Lu
2013-02-27 7:11 ` Tang Chen
2013-02-27 7:25 ` Yinghai Lu
2013-02-27 7:44 ` Tang Chen
2013-02-28 16:07 ` Yinghai Lu
2013-03-01 1:39 ` Tang Chen
2013-02-27 8:00 ` Lai Jiangshan
2013-02-27 21:26 ` Andrew Morton
2013-02-28 10:01 ` Tang Chen
2013-03-01 3:13 ` Linus Torvalds
2013-03-01 3:46 ` Tang Chen
2013-03-01 4:32 ` Linus Torvalds
2013-03-01 4:38 ` H. Peter Anvin
[not found] ` <CAE9FiQXb7K=QTR4PgMdNSoPm2LgYkxAuXUUZ0BXtgicQOGOaUA@mail.gmail.com>
2013-03-01 6:02 ` Yasuaki Ishimatsu
2013-03-01 7:55 ` Yinghai Lu
2013-03-01 15:43 ` H. Peter Anvin
2013-03-01 22:51 ` [PATCH] x86, ACPI, mm: Revert movablemem_map support Yinghai Lu
2013-03-01 6:18 ` sched: CPU #1's llc-sibling CPU #0 is not on the same node! Tang Chen
2013-03-01 8:02 ` Yinghai Lu
2013-03-01 8:39 ` Yasuaki Ishimatsu
2013-03-01 7:43 ` Yinghai Lu
2013-03-01 11:32 ` Tang Chen
2013-03-01 19:31 ` Yinghai Lu
[not found] ` <CAD11hGx5N9Eqy5bX-SEv9c7oR6Ehz2pUJwdrK0Q=L4S44RC5gg@mail.gmail.com>
2013-03-02 5:46 ` Yinghai Lu
2013-03-01 4:40 ` Andrew Morton
2013-02-27 12:40 ` Don Morris
2013-02-27 16:28 ` Luck, Tony
2013-02-27 17:30 ` Yinghai Lu
2013-02-27 17:50 ` Luck, Tony
2013-02-27 2:14 ` Tang Chen
2013-02-27 2:24 ` Yinghai Lu
2013-02-27 4:32 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512C6462.3030602@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=don.morris@hp.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox