From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ian Lartey <ian@slimlogic.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH] gpio: palmas: add in GPIO support for palmas charger
Date: Tue, 26 Feb 2013 19:28:13 +0530 [thread overview]
Message-ID: <512CBF75.9000103@nvidia.com> (raw)
In-Reply-To: <1361884868-27783-1-git-send-email-ian@slimlogic.co.uk>
On Tuesday 26 February 2013 06:51 PM, Ian Lartey wrote:
> this patch depenfs on [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers
>
> Palmas charger has 16 GPIOs
> add palmas_gpio_[read|write|update] api to take account
> second bank of GPIOs
>
> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> ---
>
> + /* palmas charger has 16 gpios */
> + if (is_palmas_charger(palmas->product_id))
> + palmas_gpio->gpio_chip.ngpio = 16;
> +
what happen if it is not palma charger?
palmas_gpio->gpio_chip.ngpio = 8; is missing or it will overwrite somewhere.
next prev parent reply other threads:[~2013-02-26 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 13:21 [PATCH] gpio: palmas: add in GPIO support for palmas charger Ian Lartey
2013-02-26 13:58 ` Laxman Dewangan [this message]
2013-02-26 14:13 ` Ian Lartey
[not found] ` <512CC357.9040600@nvidia.com>
2013-03-22 7:55 ` Linus Walleij
2013-03-22 8:37 ` Ian Lartey
-- strict thread matches above, loose matches on Subject: below --
2013-02-26 14:49 Ian Lartey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512CBF75.9000103@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=ian@slimlogic.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox