From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758181Ab3BZOMl (ORCPT ); Tue, 26 Feb 2013 09:12:41 -0500 Received: from slimlogic.co.uk ([89.16.172.20]:47708 "EHLO slimlogic.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852Ab3BZOMk (ORCPT ); Tue, 26 Feb 2013 09:12:40 -0500 Message-ID: <512CC2D6.1010705@slimlogic.co.uk> Date: Tue, 26 Feb 2013 14:12:38 +0000 From: Graeme Gregory User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Laxman Dewangan CC: Ian Lartey , "linux-kernel@vger.kernel.org" , "grant.likely@secretlab.ca" , "linus.walleij@linaro.org" , "sameo@linux.intel.com" Subject: Re: [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers References: <1361884572-27606-1-git-send-email-ian@slimlogic.co.uk> <512CC021.4060201@nvidia.com> In-Reply-To: <512CC021.4060201@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/13 14:01, Laxman Dewangan wrote: > On Tuesday 26 February 2013 06:46 PM, Ian Lartey wrote: >> is_palmas_charger checks for the presence of charging >> functionality in the device >> >> Signed-off-by: Graeme Gregory >> Signed-off-by: Ian Lartey >> --- >> include/linux/mfd/palmas.h | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h >> index 3129f9a..98c0567 100644 >> --- a/include/linux/mfd/palmas.h >> +++ b/include/linux/mfd/palmas.h >> @@ -26,6 +26,11 @@ >> /* The ID_REVISION NUMBERS */ >> #define PALMAS_CHIP_OLD_ID 0x0000 >> #define PALMAS_CHIP_ID 0xC035 >> +#define PALMAS_CHIP_CHARGER_ID 0xC036 >> + >> +#define is_palmas(a) (((a) == PALMAS_CHIP_OLD_ID) || \ >> + ((a) == PALMAS_CHIP_ID)) >> +#define is_palmas_charger(a) ((a) == PALMAS_CHIP_CHARGER_ID) >> > > TI says this as TPS80036 and original palma as TPS65913/TPS65914. Not > sure whether palma_charger is correct or not here. > > But above change looks good. > > Acked-by: Laxman Dewangan I can confirm that the generic name of TPS80036 is palmas-charger as decided at TI! Graeme