Re: [PATCH 1/5] metag: Provide dma_get_sgtable()

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hello,

On 2/26/2013 12:03 PM, James Hogan wrote:
> metag/allmodconfig:
>
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function 'vb2_dc_get_base_sgt':
> drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function 'dma_get_sgtable'
>
> For architectures using dma_map_ops, dma_get_sgtable() is provided in
> <asm-generic/dma-mapping-common.h>.
>
> Metag does not use dma_map_ops yet, hence it should implement it as an
> inline stub using dma_common_get_sgtable().
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   arch/metag/include/asm/dma-mapping.h | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/metag/include/asm/dma-mapping.h b/arch/metag/include/asm/dma-mapping.h
> index b5f80a6..14b23ef 100644
> --- a/arch/metag/include/asm/dma-mapping.h
> +++ b/arch/metag/include/asm/dma-mapping.h
> @@ -180,4 +180,11 @@ dma_cache_sync(struct device *dev, void *vaddr, size_t size,
>   {
>   }
>   
> +/* drivers/base/dma-mapping.c */
> +extern int dma_common_get_sgtable(struct device *dev, struct sg_table *sgt,
> +				  void *cpu_addr, dma_addr_t dma_addr,
> +				  size_t size);
> +
> +#define dma_get_sgtable(d, t, v, h, s) dma_common_get_sgtable(d, t, v, h, s)
> +
>   #endif

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center