public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: roger.pau@citrix.com, stefano.stabellini@eu.citrix.com,
	xen-devel <xen-devel@lists.xen.org>,
	konrad.wilk@oracle.com, dgdegra@tycho.nsa.gov,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized
Date: Wed, 27 Feb 2013 18:38:11 +0800	[thread overview]
Message-ID: <512DE213.3050001@asianux.com> (raw)
In-Reply-To: <512DE6B302000078000C1631@nat28.tlf.novell.com>

于 2013年02月27日 17:57, Jan Beulich 写道:
> You also could have mentioned that even before commit 
> 01c681d4c70d64cb72142a2823f27c4146a02e63 the value printed
> here was bogus, as it was the guest provided value from
> req->u.rw.handle rather than the actual device.

  pardon ?

  I guess what you said is :
    my patch seems ok, but the comments need improving.
    need add "additional info" in comments:
      "before commit 01c681d4c70d64cb72142a2823f27c4146a02e63
       the value printed here was bogus, as it was the guest
       provided value from req->u.rw.handle rather than the
       actual device".

  is it correct ?

  thanks.

-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-02-27 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27  4:52 [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized Chen Gang
2013-02-27  9:49 ` Jan Beulich
2013-02-27  9:50 ` Roger Pau Monné
2013-02-27 10:03   ` Jan Beulich
2013-02-27  9:57 ` Jan Beulich
2013-02-27 10:38   ` Chen Gang [this message]
2013-02-27 10:45     ` Jan Beulich
2013-02-27 15:40       ` Konrad Rzeszutek Wilk
2013-02-28  1:20         ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512DE213.3050001@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=JBeulich@suse.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox