Re: [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution

maximilian attems
2013-02-28T07:32:41Z

On Wed, Feb 27, 2013 at 02:55:45PM +0100, Michal Marek wrote:
> Sorry I missed this series. Max, can you have a look? I don't know the
> policies for debian package changelogs. The full series is at
> http://lkml.indiana.edu/hypermail/linux/kernel/1204.2/index.html#04252,
> but the remaining two patches are obvious.

the two remaining ones are trivial, should have pushed them a long time
ago and will do so this weekend in a combined version going up to 2013
(sitting in my queue to send).

> On 24.4.2012 00:16, Sedat Dilek wrote:
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> > ---
> > scripts/package/builddeb | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index eee5f8e..f5b56ac 100644
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -172,9 +172,22 @@ else
> > fi
> > maintainer="$name <$email>"
> >
> > +# Try to determine distribution
> > +if [ -e $(which lsb_release) ]; then
> > + codename=$(lsb_release --codename --short)
> > + if [ "$codename" != "" ]; then
> > + distribution=$codename
> > + else
> > + distribution="UNRELEASED"
> > + echo "WARNING: The distribution could NOT be determined!"
> > + fi
> > +else
> > + echo "HINT: Install lsb_release binary, this helps to identify your distribution!"
> > +fi
> > +
> > # Generate a simple changelog template
> > cat <<EOF > debian/changelog
> > -linux-upstream ($packageversion) unstable; urgency=low
> > +linux-upstream ($packageversion) $distribution; urgency=low
> >
> > * Custom built Linux kernel.

this is pretty useless.
Nack, in adding a this additional lsb dep.
I know it should be installed by default, but in practise it is often not.

If you'd really care about the changelog you'd generate it out of your
git repo with Debian's git dch in order to have something meaningful.

--
maks