From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760042Ab3B0Okb (ORCPT ); Wed, 27 Feb 2013 09:40:31 -0500 Received: from mail.free-electrons.com ([94.23.35.102]:57668 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865Ab3B0Oka (ORCPT ); Wed, 27 Feb 2013 09:40:30 -0500 Message-ID: <512E1AD9.4090403@free-electrons.com> Date: Wed, 27 Feb 2013 15:40:25 +0100 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Heikki Krogerus , Jamie Iles CC: Greg Kroah-Hartman , Jason Cooper , Andrew Lunn , Thomas Petazzoni , Ezequiel Garcia , "linux-kernel@vger.kernel.org" Subject: Serial port initialization broken on Armada 370/XP due to "serial: 8250_dw: Don't use UPF_FIXED_TYPE" X-Enigmail-Version: 1.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, when I tried to use the linux-next git tree (next-20130226), I encountered a problem during boot: the serial port was no more initialized on my Armada XP (ARM SoC) base board . I get: [...] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled sata_mv d00a0000.sata: slots 32 ports 2 [...] turn off boot console earlycon0 And then nothing. So after git bisect I ended to the commit " serial: 8250_dw: Don't use UPF_FIXED_TYPE". Then by adding again the UPF_FIXED_TYPE flag (ie reverting this commit) I got the usual boot log: [...] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled d0012000.serial: ttyS0 at MMIO 0xd0012000 (irq = 17) is a 8250 console [ttyS0] enabled, bootconsole disabled console [ttyS0] enabled, bootconsole disabled d0012100.serial: ttyS1 at MMIO 0xd0012100 (irq = 18) is a 8250 d0012200.serial: ttyS2 at MMIO 0xd0012200 (irq = 29) is a 8250 d0012300.serial: ttyS3 at MMIO 0xd0012300 (irq = 30) is a 8250 sata_mv d00a0000.sata: slots 32 ports 2 [...] Freeing init memory: 2160K Starting logging: OK Initializing random number generator... done. Starting network... Welcome to Buildroot buildroot login: I understand that the purpose of this commit was to let the driver find by itself the port type, but I didn't find yet how it managed to do it and then why it failed in our case. I will continue to investigate but any pointers are welcome. Thanks, -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com