From: Stephen Warren <swarren@wwwdotorg.org>
To: J Keerthy <j-keerthy@ti.com>
Cc: broonie@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, gg@slimlogic.co.uk
Subject: Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
Date: Wed, 27 Feb 2013 11:35:16 -0700 [thread overview]
Message-ID: <512E51E4.902@wwwdotorg.org> (raw)
In-Reply-To: <1361164446-3216-1-git-send-email-j-keerthy@ti.com>
On 02/17/2013 10:14 PM, J Keerthy wrote:
> Removing duplicate assignment in the existing code.
...
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
...
> @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device *dev,
> pdata->reg_init[idx]->mode_sleep = prop;
>
> ret = of_property_read_u32(palmas_matches[idx].of_node,
> - "ti,warm_reset", &prop);
> - if (!ret)
> - pdata->reg_init[idx]->warm_reset = prop;
> -
> - ret = of_property_read_u32(palmas_matches[idx].of_node,
Can you point out where the duplicate of that is; I don't see any other
assignment to warm_reset.
next prev parent reply other threads:[~2013-02-27 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 5:14 [PATCH 3/4] regulator: palmas: Removing duplicated code J Keerthy
2013-02-18 8:24 ` Graeme Gregory
2013-02-18 8:34 ` J, KEERTHY
2013-02-27 18:35 ` Stephen Warren [this message]
2013-02-28 5:22 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E51E4.902@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox