From: John Stultz <john.stultz@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Erik Gilling <konkers@android.com>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Rob Clark <robclark@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
dri-devel@lists.freedesktop.org,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 10/30] staging: sync: Export sync API symbols
Date: Thu, 28 Feb 2013 19:59:14 -0800 [thread overview]
Message-ID: <51302792.6040408@linaro.org> (raw)
In-Reply-To: <20130301020008.GB13367@kroah.com>
On 02/28/2013 06:00 PM, Greg KH wrote:
> On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote:
>> From: Erik Gilling <konkers@android.com>
>>
>> This is needed to allow modules to link against the sync subsystem
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
>> Cc: Erik Gilling <konkers@android.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Rob Clark <robclark@gmail.com>
>> Cc: Sumit Semwal <sumit.semwal@linaro.org>
>> Cc: Greg KH <gregkh@linuxfoundation.org>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: Android Kernel Team <kernel-team@android.com>
>> Signed-off-by: Erik Gilling <konkers@android.com>
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>> ---
>> drivers/staging/android/sync.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
>> index 54f84d9..6739a84 100644
>> --- a/drivers/staging/android/sync.c
>> +++ b/drivers/staging/android/sync.c
>> @@ -15,6 +15,7 @@
>> */
>>
>> #include <linux/debugfs.h>
>> +#include <linux/export.h>
>> #include <linux/file.h>
>> #include <linux/fs.h>
>> #include <linux/kernel.h>
>> @@ -64,6 +65,7 @@ struct sync_timeline *sync_timeline_create(const struct sync_timeline_ops *ops,
>>
>> return obj;
>> }
>> +EXPORT_SYMBOL(sync_timeline_create);
> As these are now global, should they be a bit more "specific"? "sync_"
> seems pretty broad.
Given its the sync driver, its most obvious choice, but I agree its
likely to collide with filesystem related or other sync_ named functions
that don't have a subsystem prefix.
Any suggestions?
The only good alternative I can think of is that in some private
conversations with DanielV, he referred to Android using "sync-points".
Erik: Would syncpoint_ be an ok prefix? Or do you have other ideas?
> Also, EXPORT_SYMBOL_GPL() perhaps?
>
> And who is using these exports?
From some quick git grepping...
In the android exynos tree:
https://android.googlesource.com/kernel/exynos.git
android-exynos-manta-3.4-jb-mr1.1
drivers/gpu/arm/t6xx/kbase/src/linux/mali_kbase_sync.c: tl =
sync_timeline_creat
drivers/media/video/videobuf2-core.c: q->timeline =
sw_sync_timeline_create(q-
drivers/video/s3c-fb.c: sfb->timeline = sw_sync_timeline_create("s3c-fb");
In the android msm tree:
https://android.googlesource.com/kernel/msm.git
android-msm-mako-3.4-jb-mr1.1
drivers/gpu/msm/kgsl_sync.c: context->timeline =
sync_timeline_create(&kgsl_s
drivers/video/msm/msm_fb.c: mfd->timeline =
sw_sync_timeline_create(
thanks
-john
next prev parent reply other threads:[~2013-03-01 3:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 0:42 [RFC][PATCH 00/30] staging: Android sync driver John Stultz
2013-03-01 0:42 ` [PATCH 01/30] staging: sync: Add synchronization framework John Stultz
2013-03-01 0:42 ` [PATCH 02/30] staging: sw_sync: Add cpu based sync driver John Stultz
2013-03-01 0:42 ` [PATCH 03/30] staging: sync: Add timestamps to sync_pts John Stultz
2013-03-01 0:43 ` [PATCH 04/30] staging: sync: Add debugfs support John Stultz
2013-03-01 0:43 ` [PATCH 05/30] staging: sw_sync: Add debug support John Stultz
2013-03-01 0:43 ` [PATCH 06/30] staging: sync: Add ioctl to get fence data John Stultz
2013-03-01 0:43 ` [PATCH 07/30] staging: sw_sync: Add fill_driver_data support John Stultz
2013-03-01 0:43 ` [PATCH 08/30] staging: sync: Add poll support John Stultz
2013-03-01 0:43 ` [PATCH 09/30] staging: sync: Allow async waits to be canceled John Stultz
2013-03-01 0:43 ` [PATCH 10/30] staging: sync: Export sync API symbols John Stultz
2013-03-01 2:00 ` Greg KH
2013-03-01 3:59 ` John Stultz [this message]
2013-03-01 8:21 ` Erik Gilling
2013-03-01 13:55 ` Greg KH
2013-03-01 16:30 ` Erik Gilling
2013-03-01 22:47 ` Erik Gilling
2013-03-01 0:43 ` [PATCH 11/30] staging: sw_sync: Export sw_sync API John Stultz
2013-03-01 0:43 ` [PATCH 12/30] staging: sync: Reorder sync_fence_release John Stultz
2013-03-01 0:43 ` [PATCH 13/30] staging: sync: Optimize fence merges John Stultz
2013-03-01 0:43 ` [PATCH 14/30] staging: sync: Add internal refcounting to fences John Stultz
2013-03-01 0:43 ` [PATCH 15/30] staging: sync: Add reference counting to timelines John Stultz
2013-03-01 0:43 ` [PATCH 16/30] staging: sync: Fix error paths John Stultz
2013-03-01 0:43 ` [PATCH 17/30] staging: sw_sync: " John Stultz
2013-03-01 0:43 ` [PATCH 18/30] staging: sync: Change wait timeout to mirror poll semantics John Stultz
2013-03-01 0:43 ` [PATCH 19/30] staging: sync: Dump sync state to console on timeout John Stultz
2013-03-01 0:43 ` [PATCH 20/30] staging: sync: Improve timeout dump messages John Stultz
2013-03-01 0:43 ` [PATCH 21/30] staging: sync: Dump sync state on fence errors John Stultz
2013-03-01 0:43 ` [PATCH 22/30] staging: sync: Protect unlocked access to fence status John Stultz
2013-03-01 0:43 ` [PATCH 23/30] staging: sync: Update new fence status with sync_fence_signal_pt John Stultz
2013-03-01 0:43 ` [PATCH 24/30] staging: sync: Use proper barriers when waiting indefinitely John Stultz
2013-03-01 0:43 ` [PATCH 25/30] staging: sync: Refactor sync debug printing John Stultz
2013-03-01 0:43 ` [PATCH 26/30] staging: sw_sync: Convert to use new value_str debug ops John Stultz
2013-03-01 0:43 ` [PATCH 27/30] staging: sync: Add tracepoint support John Stultz
2013-03-01 0:43 ` [PATCH 28/30] staging: sync: Fix race condition between merge and signal John Stultz
2013-03-01 0:43 ` [PATCH 29/30] staging: sync: Don't log wait timeouts when timeout = 0 John Stultz
2013-03-01 0:43 ` [PATCH 30/30] staging: sync: Fix timeout = 0 wait behavior John Stultz
2013-03-01 1:59 ` [RFC][PATCH 00/30] staging: Android sync driver Greg KH
2013-03-01 16:20 ` Erik Gilling
2013-03-03 18:42 ` Daniel Vetter
2013-03-03 18:52 ` animelovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51302792.6040408@linaro.org \
--to=john.stultz@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=robclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox