From: Ian Lartey <ian@slimlogic.co.uk>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH v2 2/2] mfd: palmas add variant and OTP detection
Date: Fri, 01 Mar 2013 23:42:34 +0000 [thread overview]
Message-ID: <51313CEA.4050300@slimlogic.co.uk> (raw)
In-Reply-To: <512CBE50.4050206@nvidia.com>
On 26/02/13 13:53, Laxman Dewangan wrote:
> On Saturday 23 February 2013 10:05 PM, Ian Lartey wrote:
>> From: Graeme Gregory <gg@slimlogic.co.uk>
>>
>> Read the chip varient and the OTP information from the chip and display
>> this on probe to aid in debugging of issues.
>>
>> Older palmas chips do not have the USB_ID programmed and will therefore
>> return 0x0000 for this field.
>
>> +
>> /* Change IRQ into clear on read mode for efficiency */
>> slave = PALMAS_BASE_TO_SLAVE(PALMAS_INTERRUPT_BASE);
>> - addr = PALMAS_BASE_TO_REG(PALMAS_INTERRUPT_BASE, PALMAS_INT_CTRL);
>> reg = PALMAS_INT_CTRL_INT_CLEAR;
>> - regmap_write(palmas->regmap[slave], addr, reg);
>> + ret = palmas_write(palmas, PALMAS_INTERRUPT_BASE,
>> PALMAS_INT_CTRL, reg);
>
> I think this is unrelated change and can be on another patch.
This is the change which you requested earlier "Can you please use the
api palmas_* for reading register which I added recently."
>
>>
>> - slave = PALMAS_BASE_TO_SLAVE(PALMAS_PU_PD_OD_BASE);
>> - addr = PALMAS_BASE_TO_REG(PALMAS_PU_PD_OD_BASE,
>> - PALMAS_PRIMARY_SECONDARY_PAD1);
>> -
>> if (pdata->mux_from_pdata) {
>> reg = pdata->pad1;
>> - ret = regmap_write(palmas->regmap[slave], addr, reg);
>> + ret = palmas_write(palmas, PALMAS_PU_PD_OD_BASE,
>> + PALMAS_PRIMARY_SECONDARY_PAD1, reg);
>
> Same, in another patch and elsewhere which was part of cleanups.
ditto.
>
>
> otherwise it looks good.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-03-01 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 16:35 [PATCH v2 1/2] regulator: palmas fix SMPS no voltages Ian Lartey
2013-02-23 16:35 ` [PATCH v2 2/2] mfd: palmas add variant and OTP detection Ian Lartey
2013-02-26 13:53 ` Laxman Dewangan
2013-03-01 23:42 ` Ian Lartey [this message]
2013-03-01 7:42 ` [PATCH v2 1/2] regulator: palmas fix SMPS no voltages Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51313CEA.4050300@slimlogic.co.uk \
--to=ian@slimlogic.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox