From: Graeme Gregory <gg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>,
"ian@slimlogic.co.uk" <ian@slimlogic.co.uk>
Subject: Re: [PATCH] mfd: palmas: provide irq flags through DT/platform data
Date: Sat, 02 Mar 2013 20:13:35 +0800 [thread overview]
Message-ID: <5131ECEF.2080101@slimlogic.co.uk> (raw)
In-Reply-To: <20130302033525.GD6610@opensource.wolfsonmicro.com>
On 02/03/13 11:35, Mark Brown wrote:
> On Fri, Mar 01, 2013 at 12:34:40PM -0700, Stephen Warren wrote:
>
>> Is Palmas a family of chips rather than a single chip then? That
>> implies that the DT would need two compatible values, e.g.:
> Yes.
>
>> compatible = "ti,12345", "ti,palmas";
>> ... where "12345" is the actual chip name.
>> ... rather than just the following which IIRC was in the example in
>> the DT binding document in another patch series:
>> compatible = "ti,palmas";
> Indeed, and in fact this has already been done for the I2C device ID
> table. We should have the same list of devices in the OF IDs.
Currently all members of the palmas family I know about (from memory).
For palmas :-
twl6035, twl6037, tps65913, tps65914
For palmas-charger :-
twl6036, tps80036
All with varying IP blocks or hardware configuration.
Mainly this is due to misunderstanding I had of DT definitions when I
originally read docs, when driver project commenced. I will work with
Ian, Laxman, Keerthy and get these updated.
Should these also flow down into the various drivers for the IP blocks? eg.
compatible = "ti,twl6035-regulator", "ti,palmas-regulator";
Graeme
next prev parent reply other threads:[~2013-03-02 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 12:34 [PATCH] mfd: palmas: provide irq flags through DT/platform data Laxman Dewangan
2013-03-01 12:43 ` Mark Brown
2013-03-01 12:55 ` Laxman Dewangan
2013-03-01 13:16 ` Mark Brown
2013-03-01 19:34 ` Stephen Warren
2013-03-02 3:35 ` Mark Brown
2013-03-02 12:13 ` Graeme Gregory [this message]
2013-03-02 12:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5131ECEF.2080101@slimlogic.co.uk \
--to=gg@slimlogic.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ian@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox