From: Li Zefan <lizefan@huawei.com>
To: Tommi Rantala <tt.rantala@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
<containers@lists.linux-foundation.org>,
<cgroups@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>
Subject: Re: cgroup_release_agent() hung task warnings
Date: Mon, 4 Mar 2013 10:59:58 +0800 [thread overview]
Message-ID: <51340E2E.4070805@huawei.com> (raw)
In-Reply-To: <CA+ydwtrRAf5VW_iZYOjzmTv6Y0ebprXw_RfWVmR1okQOxQx=CA@mail.gmail.com>
On 2013/3/3 3:23, Tommi Rantala wrote:
> Hello,
>
> I'm seeing the following hung task warnings when fuzzing the kernel
> with trinity (in a qemu virtual machine, as the root user), that I
> have not seen before with 3.8 or earlier. The kernel is
> b0af9cd9aab60ceb17d3ebabb9fdf4ff0a99cf50 (Merge tag
> 'lzo-update-signature-20130226' of
> git://github.com/markus-oberhumer/linux).
>
This doesn't look like a cgroup bug.
...
> [ 120.594088] INFO: task kworker/0:2:1079 blocked for more than 60 seconds.
> [ 120.595877] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> disables this message.
> [ 120.598100] kworker/0:2 D ffff88007c518618 0 1079 2 0x00000000
> [ 120.599958] ffff88007adc9a38 0000000000000046 ffff88007b0b0000
> ffff88007adc9fd8
> [ 120.601982] ffff88007adc9fd8 ffff88007adc9fd8 ffff88007c518000
> ffff88007b0b0000
> [ 120.603994] ffff88007adc9a18 ffff88007adc9b88 ffff88007adc9b90
> 7fffffffffffffff
> [ 120.606003] Call Trace:
> [ 120.606684] [<ffffffff81cd9d95>] schedule+0x55/0x60
> [ 120.607973] [<ffffffff81cd7786>] schedule_timeout+0x36/0x240
> [ 120.609460] [<ffffffff810f3303>] ? mark_held_locks+0x123/0x140
> [ 120.610932] [<ffffffff81cdb99b>] ? _raw_spin_unlock_irq+0x2b/0x40
> [ 120.612521] [<ffffffff810f3475>] ? trace_hardirqs_on_caller+0x155/0x1f0
> [ 120.614471] [<ffffffff810f351d>] ? trace_hardirqs_on+0xd/0x10
> [ 120.615957] [<ffffffff81cda037>] wait_for_completion+0x97/0x100
> [ 120.617495] [<ffffffff810d2310>] ? try_to_wake_up+0x340/0x340
> [ 120.619013] [<ffffffff810b615c>] call_usermodehelper_exec+0x14c/0x210
> [ 120.620613] [<ffffffff81cd9fcc>] ? wait_for_completion+0x2c/0x100
> [ 120.622187] [<ffffffff810b6948>] call_usermodehelper_fns+0xe8/0x100
> [ 120.623821] [<ffffffff8110921a>] cgroup_release_agent+0x15a/0x180
> [ 120.625374] [<ffffffff810b85cb>] process_one_work+0x29b/0x4c0
> [ 120.626861] [<ffffffff810b8560>] ? process_one_work+0x230/0x4c0
> [ 120.628407] [<ffffffff810b8da8>] worker_thread+0x248/0x380
> [ 120.630183] [<ffffffff810b8b60>] ? busy_worker_rebind_fn+0xb0/0xb0
> [ 120.631761] [<ffffffff810bfd71>] kthread+0xd1/0xe0
> [ 120.633019] [<ffffffff810f351d>] ? trace_hardirqs_on+0xd/0x10
> [ 120.634479] [<ffffffff810bfca0>] ? __kthread_bind+0x40/0x40
> [ 120.635898] [<ffffffff81cdcdfc>] ret_from_fork+0x7c/0xb0
> [ 120.637254] [<ffffffff810bfca0>] ? __kthread_bind+0x40/0x40
The completion was never done:
static
int call_usermodehelper_exec(struct subprocess_info *sub_info, int wait)
{
DECLARE_COMPLETION_ONSTACK(done);
...
sub_info->complete = &done;
sub_info->wait = wait;
queue_work(khelper_wq, &sub_info->work);
...
wait_for_completion(&done);
...
return retval;
}
It should be done here:
static void __call_usermodehelper(struct work_struct *work)
{
...
pid = kernel_thread(call_helper, sub_info,
CLONE_VFORK | SIGCHLD);
...
switch (wait) {
...
case UMH_WAIT_EXEC:
if (pid < 0)
sub_info->retval = pid;
umh_complete(sub_info);
}
}
You may need to add some printks to see why completion can't be done.
Maybe khelper_wq was blocked and couldn't schedule any work?
next prev parent reply other threads:[~2013-03-04 3:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 19:23 cgroup_release_agent() hung task warnings Tommi Rantala
2013-03-04 2:59 ` Li Zefan [this message]
2013-03-04 17:33 ` Tejun Heo
2013-03-05 1:28 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51340E2E.4070805@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox