Re: [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED

Hu Tao
2013-03-06T09:03:21Z

On Tue, Mar 05, 2013 at 09:26:18AM +0100, Paolo Bonzini wrote:
> Il 05/03/2013 04:17, Hu Tao ha scritto:
> > Will
> >
> > if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
> > runstate_check(RUN_STATE_SHUTDOWN) ||
> > runstate_check(RUN_STATE_GUEST_PANICKED)) {
> > runstate_set(RUN_STATE_PAUSED);
> > }
> >
> > be OK? Or I must be misunderstanding you.
> >
>
> Please move
>
> return (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
> runstate_check(RUN_STATE_SHUTDOWN) ||
> runstate_check(RUN_STATE_GUEST_PANICKED));
>
> to a separate function (runstate_needs_reset for example), so that you
> can reuse it in the two or three places that need it.

See it now. Thanks!