From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757602Ab3CEQsR (ORCPT ); Tue, 5 Mar 2013 11:48:17 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:34346 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754666Ab3CEQsP (ORCPT ); Tue, 5 Mar 2013 11:48:15 -0500 Message-ID: <513621CA.5010906@wwwdotorg.org> Date: Tue, 05 Mar 2013 09:48:10 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, balbi@ti.com, gregkh@linuxfoundation.org, s-guiriec@ti.com, gg@slimlogic.co.uk, sameo@linux.intel.com, broonie@opensource.wolfsonmicro.com, ldewangan@nvidia.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/4] USB: Palmas OTG Transceiver Driver References: <1362493320-13913-1-git-send-email-kishon@ti.com> <1362493320-13913-4-git-send-email-kishon@ti.com> In-Reply-To: <1362493320-13913-4-git-send-email-kishon@ti.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2013 07:21 AM, Kishon Vijay Abraham I wrote: > From: Graeme Gregory > > This is the driver for the OTG transceiver built into the Palmas chip. It > handles the various USB OTG events that can be generated by cable > diff --git a/Documentation/devicetree/bindings/usb/twlxxxx-usb.txt b/Documentation/devicetree/bindings/usb/twlxxxx-usb.txt > +palmas-usb { > + compatible = "ti,palmas-usb"; The example should probably demonstrate best DT practices, and include a specific chip name in the compatible value too. In other words, something like: compatible = "ti,twl12345-usb", "ti,palmas-usb";