From: Stephen Warren <swarren@wwwdotorg.org>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Samuel Ortiz <sameo@linux.intel.com>,
Anton Vorontsov <cbou@mail.ru>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-tegra@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] power_supply: tps65090-charger: Add binding doc
Date: Tue, 05 Mar 2013 11:15:39 -0700 [thread overview]
Message-ID: <5136364B.7000506@wwwdotorg.org> (raw)
In-Reply-To: <1362423709-29596-4-git-send-email-rklein@nvidia.com>
On 03/04/2013 12:01 PM, Rhyland Klein wrote:
> This change adds the binding documentation for the tps65090-charger.
> diff --git a/Documentation/devicetree/bindings/power_supply/tps65090.txt b/Documentation/devicetree/bindings/power_supply/tps65090.txt
...
> +Example:
> +
> + tps65090@48 {
...
> + regulators {
> + ...
> + };
>
The "regulators" node in the example isn't mentioned in the list of
properties/nodes that's above. What goes in there? You probably want to
include text similar to what I've quoted below from
Documentation/devicetree/bindings/regulator/tps6586x.txt:
> - regulators: A node that houses a sub-node for each regulator within the
> device. Each sub-node is identified using the node's name (or the deprecated
> regulator-compatible property if present), with valid values listed below.
> The content of each sub-node is defined by the standard binding for
> regulators; see regulator.txt.
> sys, sm[0-2], ldo[0-9] and ldo_rtc
next prev parent reply other threads:[~2013-03-05 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 19:01 [PATCH v2 0/4] Add support for tps65090-charger Rhyland Klein
2013-03-04 19:01 ` [PATCH v2 1/4] mfd: tps65090: Fix enum in header file Rhyland Klein
2013-03-04 19:01 ` [PATCH v2 2/4] mfd: tps65090: Add resources for charger Rhyland Klein
2013-03-04 19:01 ` [PATCH v2 3/4] power_supply: tps65090-charger: Add binding doc Rhyland Klein
2013-03-05 18:15 ` Stephen Warren [this message]
2013-03-05 19:12 ` Rhyland Klein
2013-03-05 19:25 ` Stephen Warren
2013-03-04 19:01 ` [PATCH v2 4/4] power: tps65090: Add support for tps65090-charger Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5136364B.7000506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbou@mail.ru \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox