* [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)!
@ 2013-03-05 18:37 Raphael S.Carvalho
2013-03-05 22:02 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Raphael S.Carvalho @ 2013-03-05 18:37 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Peter Zijlstra,
Jarkko Sakkinen
Cc: linux-kernel, Raphael S.Carvalho
GCC complained about the unused variable c, thus I'm sending
this patch in order to calm it down.
I compiled the file and everything seems be ok!
Signed-off-by: Raphael S.Carvalho <raphael.scarv@gmail.com>
---
arch/x86/kernel/smpboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index a6ceaed..77a5616 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1367,7 +1367,7 @@ static inline void mwait_play_dead(void)
unsigned int highest_subcstate = 0;
int i;
void *mwait_ptr;
- struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
+ __this_cpu_ptr(&cpu_info);
if (!this_cpu_has(X86_FEATURE_MWAIT))
return;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)!
2013-03-05 18:37 [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)! Raphael S.Carvalho
@ 2013-03-05 22:02 ` Thomas Gleixner
2013-03-05 22:08 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2013-03-05 22:02 UTC (permalink / raw)
To: Raphael S.Carvalho
Cc: Ingo Molnar, H. Peter Anvin, x86, Peter Zijlstra, Jarkko Sakkinen,
linux-kernel
On Tue, 5 Mar 2013, Raphael S.Carvalho wrote:
> GCC complained about the unused variable c, thus I'm sending
> this patch in order to calm it down.
> I compiled the file and everything seems be ok!
What is your patch solving? How about removing the line completely?
And how about providing a changelog which makes sense ?
Thanks,
tglx
> Signed-off-by: Raphael S.Carvalho <raphael.scarv@gmail.com>
> ---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a6ceaed..77a5616 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1367,7 +1367,7 @@ static inline void mwait_play_dead(void)
> unsigned int highest_subcstate = 0;
> int i;
> void *mwait_ptr;
> - struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
> + __this_cpu_ptr(&cpu_info);
>
> if (!this_cpu_has(X86_FEATURE_MWAIT))
> return;
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)!
2013-03-05 22:02 ` Thomas Gleixner
@ 2013-03-05 22:08 ` H. Peter Anvin
0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2013-03-05 22:08 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Raphael S.Carvalho, Ingo Molnar, x86, Peter Zijlstra,
Jarkko Sakkinen, linux-kernel
On 03/05/2013 02:02 PM, Thomas Gleixner wrote:
>
> What is your patch solving? How about removing the line completely?
> And how about providing a changelog which makes sense ?
>
> Thanks,
>
> tglx
>
We already have an actually correct patch for this warning; I will apply
it later.
-hpa
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-05 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 18:37 [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)! Raphael S.Carvalho
2013-03-05 22:02 ` Thomas Gleixner
2013-03-05 22:08 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox