* [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation
@ 2013-03-04 8:56 Jingoo Han
2013-03-04 8:59 ` Jingoo Han
2013-03-04 9:02 ` [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation Jingoo Han
0 siblings, 2 replies; 4+ messages in thread
From: Jingoo Han @ 2013-03-04 8:56 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: 'LKML', 'Richard Purdie', 'Jingoo Han'
When platform_driver_probe() is not used, bind/unbind via sysfs is
enabled. Thus, __init/__exit annotations should be removed from
probe()/remove().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/ep93xx_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index ef3e21e..fd073b2 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
.get_brightness = ep93xxbl_get_brightness,
};
-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int ep93xxbl_probe(struct platform_device *dev)
{
struct ep93xxbl *ep93xxbl;
struct backlight_device *bl;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation
2013-03-04 8:56 [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation Jingoo Han
@ 2013-03-04 8:59 ` Jingoo Han
2013-03-04 9:02 ` [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation Jingoo Han
1 sibling, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-03-04 8:59 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: 'LKML', 'Richard Purdie', 'Jingoo Han'
On Monday, March 04, 2013 5:57 PM, Jingoo Han wrote:
> Subject: [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation
Sorry, subject is wrong.
__exit should be __init.
I will send the v2 patch, soon.
>
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..fd073b2 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
> .get_brightness = ep93xxbl_get_brightness,
> };
>
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
> {
> struct ep93xxbl *ep93xxbl;
> struct backlight_device *bl;
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation
2013-03-04 8:56 [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation Jingoo Han
2013-03-04 8:59 ` Jingoo Han
@ 2013-03-04 9:02 ` Jingoo Han
2013-03-05 22:41 ` Ryan Mallon
1 sibling, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-03-04 9:02 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: 'LKML', 'Richard Purdie', 'Jingoo Han'
When platform_driver_probe() is not used, bind/unbind via sysfs is
enabled. Thus, __init/__exit annotations should be removed from
probe()/remove().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v1:
- Fix typo of the subject: __exit --> __init
drivers/video/backlight/ep93xx_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index ef3e21e..fd073b2 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
.get_brightness = ep93xxbl_get_brightness,
};
-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int ep93xxbl_probe(struct platform_device *dev)
{
struct ep93xxbl *ep93xxbl;
struct backlight_device *bl;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation
2013-03-04 9:02 ` [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation Jingoo Han
@ 2013-03-05 22:41 ` Ryan Mallon
0 siblings, 0 replies; 4+ messages in thread
From: Ryan Mallon @ 2013-03-05 22:41 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', 'LKML', 'Richard Purdie'
On 04/03/13 20:02, Jingoo Han wrote:
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Ryan Mallon <rmallon@gmail.com>
> ---
> Changes since v1:
> - Fix typo of the subject: __exit --> __init
>
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..fd073b2 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
> .get_brightness = ep93xxbl_get_brightness,
> };
>
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
> {
> struct ep93xxbl *ep93xxbl;
> struct backlight_device *bl;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-05 22:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 8:56 [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation Jingoo Han
2013-03-04 8:59 ` Jingoo Han
2013-03-04 9:02 ` [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation Jingoo Han
2013-03-05 22:41 ` Ryan Mallon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox