From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932426AbcIALR6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 07:17:58 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:64307 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755196AbcIALRw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 07:17:52 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>, javier@osg.samsung.com,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration
Date: Thu, 01 Sep 2016 13:17:13 +0200
Message-ID: <5137342.oSWmFr9Y8D@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <e37fbfa0-f30c-ab34-3428-fb9a66182089@samsung.com>
References: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com> <1608454.1ZuTJsprje@amdc1976> <e37fbfa0-f30c-ab34-3428-fb9a66182089@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:mExHWVKAYVFXNWJAJdAAPJ28srS0wdXjO0ECRezDNdqcbBiIol4
 l4lxF/Ww70smYMSifNu4gEtNnl0fW+fDr/j19xat/K8NJiwHQ3KHsOvnjEOziIXn6E7DYXC
 9g+EaqNITeiSp25eRm7tz75159EGZH3lqsUSWeuUwMLS5R1PoKd5Uoes0nqUGF4Ehg2BK4W
 QM0HSAoGBhzUS0qkxYH3w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:P4qpTg1GMOA=:0v2j0G70IPtUAKP60RYPs0
 aGa2IMnJVlmf3lv4vV/Gj1HaTetJGbXI3riwpJJRJQXNZqrkfQQvw4pDqKH2Nuno4s7o/mxEe
 FvkrZPsGXp13uYveZ6VdIVhfcY9rrZXzGTJe6JNGgfKMfXl1MYCdI211AWnH5oZsJn+90UPJa
 YZECOxqdYoIcmyzA6vaEzuxRL6Gr+u0ZINkdA4ZbNHlky/i135swrOWmlxv10/Sf2dYlII6vD
 t4XGrLVu1xWnVs+XC5F+uVwiSzHoihU/kLb7pi4DkTwg23cVItiI/EEaZDmCyoFeQuJ2A6Wjq
 cIBppgPeaE63Mz/OtafjBRPq8w/jDY2eQChr0IEiaC/vP/WyekOuBaAyf9ymCQqwE9zsuYMTP
 DCpjceTdkjo3hjgQ5zygPrxu1gV1W7ME29cD+T5+5Sqqh5MbMbVSPSGpWgdVBae4fRKskaGTi
 EJpPtDQwAhg/LF6++cA8AAKNYDGaFQoMhqn1jwaafOsvKHmHD5MyEwGdEuPEaoBNvLvRqIBvs
 I+hOKD727oVmqEjALQbZRYbWmkNGkmmu2PvwssDHxTl8MmlZOakGLdAzl3mYo1hUxZJHtC7K9
 ns+VDa70n/xx+p/8ORXB5/UKaUo5h0WzNb/n2gotckggMR4DNn0OgDw1pncGfb4kI9Pae4b3R
 50o10KtP1HSCU4axhaW7k7Mx1+SqGH5we3zmNvhEI35CF4ljw6vfjQQyqWgehcmc2r/hnIs9j
 Vz/vHwgNABmWJMen
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, September 1, 2016 1:12:18 PM CEST Krzysztof Kozlowski wrote:
> > 
> > Shouldn't macros that are also used by s3c* be named as
> > SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?
> 
> Right, this is the inconsistency. The problem with "samsung" prefix is
> that there is no guarantee it will be like that for newer SoCs. How
> about one of:
> 1. using the oldest prefix (S3C24XX in this case),
> 2. duplicating them per SoC family (so S3C24XX, S3C64XX, EXYNOS).
> ?

I'd suggest living with the inconsistency and using EXYNOS as the prefix,
as that is the most common one these days, even if the other ones
predate it.

	Arnd